Use "New Module Imports" #871
Conversation
| import loadInitializers from 'ember-load-initializers'; | ||
|
|
||
| import Resolver from './resolver'; |
There was a problem hiding this comment.
can you put resolver before loadInitializers? or did the order change in blueprints?
There was a problem hiding this comment.
my convention is usually to import external packages first before importing local files. since ember-load-initializers is external and ./resolver is a local file the resolver is imported afterwards
app/components/api-token-row.js
Outdated
| @@ -1,8 +1,9 @@ | |||
| import Ember from 'ember'; | |||
| import { empty, or } from '@ember/object/computed'; | |||
| import Component from '@ember/component'; | |||
app/components/badge-appveyor.js
Outdated
| tagName: 'span', | ||
| classNames: ['badge'], | ||
| repository: Ember.computed.alias('badge.attributes.repository'), | ||
| branch: Ember.computed('badge.attributes.branch', function() { | ||
| repository: alias('badge.attributes.repository'), |
There was a problem hiding this comment.
we might want to introduce some newlines here, for readability
| tagName: '', | ||
|
|
||
| didInsertElement() { | ||
| Ember.$.getScript('https://www.google.com/jsapi', function() { | ||
| $.getScript('https://www.google.com/jsapi', function() { |
There was a problem hiding this comment.
we won't have a problem with these?
There was a problem hiding this comment.
hm, I guess these will be short lived anyway, as we'll want to use something fastboot-compatible.
There was a problem hiding this comment.
sure, but replacing $.getScript() is unrelated to the purpose of this PR
There was a problem hiding this comment.
I know, I'm just saying it won't matter soon enough :P
see Ember.js RFC rust-lang#176
Turbo87
force-pushed
the
new-module-imports
branch
from
b7581ba to
29e9fe2
Compare
see Ember.js RFC #176 and https://github.com/ember-cli/ember-rfc176-data