Skip to content

Mention concerns for "the first person who asks" for ownership transfer #7361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Mention concerns for "the first person who asks" for ownership transfer #7361

merged 1 commit into from
Feb 22, 2024

Conversation

Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Oct 25, 2023

See #7173
And see also the npm event-stream incident.

Any feedback, especially regarding wording, is appreciated!

(CC @carols10cents since you apparently proposed adding this section in #5216)

@Marcono1234
Copy link
Contributor Author

In case this pull request is accepted in some form, should rust-lang/rfcs#3463 then be updated as well?

@Turbo87 Turbo87 requested a review from a team October 26, 2023 08:09
@Turbo87 Turbo87 added the C-documentation 📜 Category: Documentation of crates.io itself label Oct 26, 2023
@Turbo87
Copy link
Member

Turbo87 commented Oct 27, 2023

👋 we discussed this PR in the crates.io team meeting today. it seems like this paragraph applies to maintainer invitations in general, and not just to these specific situations where someone reserved a crate name and doesn't need it anymore.

since rust-lang/rfcs#3463 is now in final comment period and will hopefully be merged our suggestion is to delay this PR until we've integrated that policy update, and then we can re-evaluate where this paragraph would make most sense. does that sound good to you?

@Marcono1234
Copy link
Contributor Author

Marcono1234 commented Oct 27, 2023

it seems like this paragraph applies to maintainer invitations in general, and not just to these specific situations where someone reserved a crate name and doesn't need it anymore

Do you mean the new paragraph I added. Yes, I guess you are right. But as seen with https://crates.io/crates/wgpu-noboiler, it appears users might also apply "How can I delete a crate I own from the registry?" in other situations, where the crate was not just used to reserve the name. That was why I though this new paragraph was needed for this section the most.

delay this PR until we've integrated that policy update, and then we can re-evaluate where this paragraph would make most sense. does that sound good to you?

Yes that is completely fine for me, thanks also for discussing this PR!

@bors
Copy link
Contributor

bors commented Nov 10, 2023

☔ The latest upstream changes (presumably #7496) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 enabled auto-merge (squash) February 22, 2024 12:52
@Turbo87 Turbo87 merged commit 2c682b2 into rust-lang:main Feb 22, 2024
@Marcono1234
Copy link
Contributor Author

Thanks a lot @Turbo87 for updating this pull request and including the warning in the policies!

@Marcono1234 Marcono1234 deleted the crate-deletion-ownership-transfer branch February 28, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-documentation 📜 Category: Documentation of crates.io itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants