Add support for reverse dependencies. #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let stmt = try!(conn.prepare("SELECT dependencies.*, | ||
| crates.name AS crate_name | ||
| FROM dependencies | ||
| LEFT JOIN versions |
There was a problem hiding this comment.
Why are these left joins instead of inner joins? (I have not looked deeply at the schema so this may be a stupid question.)
There was a problem hiding this comment.
Mindless copypaste. I've adjusted it now.
|
Looks great, thanks @huonw! Can you also add some tests for the endpoint? You should see some examples in src/test/krate.rs |
| import Ember from 'ember'; | ||
|
|
||
| export default Ember.ObjectController.extend({ | ||
| }); |
There was a problem hiding this comment.
I think you can delete this whole file because its blank.
This /api/v1/crates/foo/reverse_dependencies gives the full dependency information about each crate that depends on foo (i.e. crates with `[dependencies] foo = "..."`).
This connects the web-app to the back-end API and allows it to display a list of all the reverse dependencies of a crate as a /reverse_dependencies subroute. This uses the same format as the /versions route.
This includes making some changes to the test harness, e.g. allowing dependencies to be added from multiple versions of the dependent crate.
|
OMG awesome!!!! This is so cool :) ❤️ @huonw !!! |
Turbo87
pushed a commit
to Turbo87/crates.io
that referenced
this pull request
Dec 7, 2022
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Turbo87
pushed a commit
to Turbo87/crates.io
that referenced
this pull request
Jan 4, 2023
Co-authored-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an API endpoint
.../:crate/reverse_dependenciesand a web-page/crate/:crate/reverse_dependenciesfor displaying. It's modelled after the.../versionspage, and is not currently linked from anywhere.Fixes #68.