Improve environment variable setup for development #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make using the local uploader easier in development, instead of checking if these vars are blank, start these commented out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to dotenv 0.10.0 since that version considers
key=lines to be valid with a blank value. With 0.9.0, I've seen errors because of theexport S3_REGION= # not needed if the S3 bucket is in US standardline, and the errors look like they're saying that the GIT_REPO_URL var isn't set instead, and it's terrible, and this fixes it.And actually, blank values for the S3 variables still cause the code to use the S3 uploader when I added the whole local uploader thing so that you don't have to deal with all that in development. Silly me though just straight up removed all those vars in my
.env, and I should have commented them out in.env.sampleas well to make setup for others easier out of the box.Also just added a commit to put a sample postgres URL nearer to the TEST_DATABASE_URL env var as well.