Skip to content

Add more documentation about crates.io's database needs #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2017

Conversation

carols10cents
Copy link
Member

Fixes #541.

@Susurrus
Copy link
Contributor

Susurrus commented Feb 8, 2017

@alexcrichton Quick on the draw there, I was actually just reviewing these notes by setting up a test environment on my own computer. I found them a tad confusing if you're looking to just run the tests without worrying about self-hosting a complete backend. For me, just wanting to run the tests, I skipped over the "Working on the Backend" section to get to the "Running Tests" section, but had to backtrack because steps 1 & 2 are necessary (but none of the others are) to run the tests.

Therefore I would suggest splitting the section into 3 parts:

  1. First specify that postgres needs to be installed and the backend needs a .env file.
  2. Put steps 3+ from the original "Working on the Backend" section into a "Self-hosting with the Backend" title or something.
  3. Adjust the "Running Tests" section to account for Steps 1 & 2 above.

@carols10cents carols10cents deleted the postgres-in-readme branch February 8, 2017 13:46
@carols10cents
Copy link
Member Author

@Susurrus now that the information is there and could just use some rearranging, do you have time to send in a PR for that? I'm pretty busy today :)

@Susurrus
Copy link
Contributor

Susurrus commented Feb 8, 2017

Sure! I'll do that but it might be tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants