Skip to content

TestApp: Simplify crates_from_index_head() method #4173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 13, 2021

We can calculate the path automatically from the crate_name. There is no need for us to manually specify it in the tests.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 13, 2021
@Turbo87 Turbo87 requested review from locks and JohnTitor November 13, 2021 16:43
@Turbo87 Turbo87 force-pushed the relative-index-file branch from eafb4c9 to d1f2854 Compare November 15, 2021 11:55
@JohnTitor
Copy link
Member

Looks good! @bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2021

📌 Commit d1f2854 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Nov 15, 2021

⌛ Testing commit d1f2854 with merge 372601e...

@bors
Copy link
Contributor

bors commented Nov 15, 2021

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing 372601e to master...

@bors bors merged commit 372601e into rust-lang:master Nov 15, 2021
@Turbo87 Turbo87 deleted the relative-index-file branch November 15, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants