Skip to content

sentry: Use allowUrls option to filter out errors in injected scripts #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 4, 2021

This is based on https://dzone.com/articles/6-tips-for-reducing-javascript-error-noise and filters out errors from e.g. broken browser extensions. It ensures that we only report errors that originate in the scripts served by our own servers.

@Turbo87 Turbo87 added A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Nov 4, 2021
@Turbo87 Turbo87 requested review from locks and pichfl November 4, 2021 09:11
@Turbo87 Turbo87 unassigned locks and pichfl Nov 4, 2021
@Turbo87 Turbo87 force-pushed the sentry-domains branch 3 times, most recently from e91af94 to 2c9ab50 Compare November 8, 2021 16:25
@locks
Copy link
Contributor

locks commented Nov 15, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2021

📌 Commit 299b528 has been approved by locks

@bors
Copy link
Contributor

bors commented Nov 15, 2021

⌛ Testing commit 299b528 with merge eda0d5a...

@bors
Copy link
Contributor

bors commented Nov 15, 2021

☀️ Test successful - checks-actions
Approved by: locks
Pushing eda0d5a to master...

@bors bors merged commit eda0d5a into rust-lang:master Nov 15, 2021
@Turbo87 Turbo87 deleted the sentry-domains branch November 15, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants