Avoid cloning Config struct
#3560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This struct contains a lot of owned data and cloning the entire struct is unnecessary.
jtgeibel
force-pushed
the
avoid-cloning-config
branch
from
d99f64c to
b91aa29
Compare
|
I've pushed a new commit which should fix the build error. I missed a line while trying to slip a diff into smaller PRs. |
|
@bors r+ |
|
📌 Commit b91aa29 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This struct contains a lot of owned data and cloning the entire struct
is unnecessary.
r? @Turbo87