Skip to content

Display crate description in the CrateHeader component #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 25, 2021

Bildschirmfoto 2021-02-25 um 18 52 09

This makes it easier to figure out on first glance what a crate does, without having to wait for and read through the README text.

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Feb 25, 2021
@Turbo87
Copy link
Member Author

Turbo87 commented Feb 25, 2021

Bildschirmfoto 2021-02-25 um 22 43 13

I've slightly adjusted the case where the crate does not have a README to avoid displaying the crate description twice, and I've also added a spinner for the README loading task.

@locks
Copy link
Contributor

locks commented Feb 26, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Feb 26, 2021

📌 Commit 036e953 has been approved by locks

@bors
Copy link
Contributor

bors commented Feb 26, 2021

⌛ Testing commit 036e953 with merge 575b2fb...

@bors
Copy link
Contributor

bors commented Feb 26, 2021

☀️ Test successful - checks-actions
Approved by: locks
Pushing 575b2fb to master...

@bors bors merged commit 575b2fb into rust-lang:master Feb 26, 2021
@Turbo87 Turbo87 deleted the header-description branch February 26, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants