Add COM0 and LPT0 to the list of reserved crate names #3271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunaBorowska
approved these changes
Feb 10, 2021
LunaBorowska
suggested changes
Feb 10, 2021
In rust-lang#695 we added all the documented reserved Windows file names to the list of reserved crate names, to prevent people from registering crates named that way and breaking all Windows users in the process. Unfortunately it turns out that COM0 and LPT0 are *also* reserved on Windows systems, but they're not documented in Microsoft's docs. This PR adds both names to the reserved crate names list. Note that the migration here is a no-op on the production crates.io instance, as both names were manually added to the database before opening this PR.
pietroalbini
force-pushed
the
com0-lpt0
branch
from
defef17 to
4f6b8c9
Compare
LunaBorowska
approved these changes
Feb 10, 2021
Turbo87
approved these changes
Feb 10, 2021
Turbo87
added
C-enhancement ✨
|
LGTM, thanks for handling this on production already. @bors r+ |
|
📌 Commit 4f6b8c9 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #695 we added all the documented reserved Windows file names to the list of reserved crate names, to prevent people from registering crates named that way and breaking all Windows users in the process.
Unfortunately it turns out that COM0 and LPT0 are also reserved on Windows systems, but they're not documented in Microsoft's docs. This PR adds both names to the reserved crate names list.
Note that the migration here is a no-op on the production crates.io instance, as both names were manually added to the database before opening this PR.
r? @jtgeibel