Skip to content

Implement Ember.js RFC 637 #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tests/acceptance/404-test.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import { currentURL, fillIn, triggerEvent, visit } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

module('Acceptance | 404', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('/unknown-route shows a 404 page', async function (assert) {
await visit('/unknown-route');
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/api-token-test.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import { click, currentURL, fillIn, findAll } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import percySnapshot from '@percy/ember';
import { Response } from 'ember-cli-mirage';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

import { visit } from '../helpers/visit-ignoring-abort';

module('Acceptance | api-tokens', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

function prepare(context) {
let user = context.server.create('user', {
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/categories-test.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import { visit } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import percySnapshot from '@percy/ember';
import a11yAudit from 'ember-a11y-testing/test-support/audit';

import { setupApplicationTest } from 'cargo/tests/helpers';

import axeConfig from '../axe-config';
import setupMirage from '../helpers/setup-mirage';

module('Acceptance | categories', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('listing categories', async function (assert) {
this.owner.lookup('service:intl').locale = 'en';
Expand Down
4 changes: 1 addition & 3 deletions tests/acceptance/crate-following-test.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import { click, settled, visit, waitFor } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import { defer } from 'rsvp';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

module('Acceptance | Crate following', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

function prepare(context, { loggedIn = true, following = false } = {}) {
let server = context.server;
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/crate-test.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import { click, currentRouteName, currentURL, visit, waitFor } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, skip, test } from 'qunit';

import percySnapshot from '@percy/ember';
import a11yAudit from 'ember-a11y-testing/test-support/audit';
import { getPageTitle } from 'ember-page-title/test-support';

import { setupApplicationTest } from 'cargo/tests/helpers';

import axeConfig from '../axe-config';
import setupMirage from '../helpers/setup-mirage';

module('Acceptance | crate page', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('visiting a crate page from the front page', async function (assert) {
this.server.create('crate', { name: 'nanomsg', newest_version: '0.6.1' });
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/crates-test.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import { click, currentURL, visit } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import percySnapshot from '@percy/ember';
import a11yAudit from 'ember-a11y-testing/test-support/audit';
import { getPageTitle } from 'ember-page-title/test-support';

import { setupApplicationTest } from 'cargo/tests/helpers';

import axeConfig from '../axe-config';
import setupMirage from '../helpers/setup-mirage';

module('Acceptance | crates page', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

// should match the default set in the crates controller
const per_page = 50;
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/dashboard-test.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
import { currentURL } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import percySnapshot from '@percy/ember';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

import { visit } from '../helpers/visit-ignoring-abort';

module('Acceptance | Dashboard', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('redirects to / when not logged in', async function (assert) {
await visit('/dashboard');
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/email-change-test.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import { click, currentURL, fillIn } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

import { visit } from '../helpers/visit-ignoring-abort';

module('Acceptance | Email Change', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('happy path', async function (assert) {
let user = this.server.create('user', { email: '[email protected]' });
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/email-confirmation-test.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import { currentURL } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

import { visit } from '../helpers/visit-ignoring-abort';

module('Acceptance | Email Confirmation', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('unauthenticated happy path', async function (assert) {
let user = this.server.create('user', { emailVerificationToken: 'badc0ffee' });
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/front-page-test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { click, currentURL, settled, visit, waitFor } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import { defer } from 'rsvp';
Expand All @@ -8,13 +7,13 @@ import percySnapshot from '@percy/ember';
import a11yAudit from 'ember-a11y-testing/test-support/audit';
import { getPageTitle } from 'ember-page-title/test-support';

import { setupApplicationTest } from 'cargo/tests/helpers';

import { summary } from '../../mirage/route-handlers/summary';
import axeConfig from '../axe-config';
import setupMirage from '../helpers/setup-mirage';

module('Acceptance | front page', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('visiting /', async function (assert) {
this.owner.lookup('service:intl').locale = 'en';
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/invites-test.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import { click, currentURL } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import percySnapshot from '@percy/ember';
import Response from 'ember-cli-mirage/response';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

import { visit } from '../helpers/visit-ignoring-abort';

module('Acceptance | /me/pending-invites', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

function prepare(context) {
let user = context.server.create('user');
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/keyword-test.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import { visit } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import percySnapshot from '@percy/ember';
import a11yAudit from 'ember-a11y-testing/test-support/audit';

import { setupApplicationTest } from 'cargo/tests/helpers';

import axeConfig from '../axe-config';
import setupMirage from '../helpers/setup-mirage';

module('Acceptance | keywords', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('keyword/:keyword_id index default sort is recent-downloads', async function (assert) {
this.server.create('keyword', { keyword: 'network' });
Expand Down
4 changes: 1 addition & 3 deletions tests/acceptance/login-test.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
import { click, currentURL, visit, waitFor } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import { defer } from 'rsvp';

import window from 'ember-window-mock';
import { setupWindowMock } from 'ember-window-mock/test-support';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

module('Acceptance | Login', function (hooks) {
setupApplicationTest(hooks);
setupWindowMock(hooks);
setupMirage(hooks);

test('successful login', async function (assert) {
let deferred = defer();
Expand Down
4 changes: 1 addition & 3 deletions tests/acceptance/logout-test.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import { click, currentURL, visit } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

module('Acceptance | Logout', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('successful logout', async function (assert) {
let user = this.server.create('user', { name: 'John Doe' });
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/owners-test.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import { click, fillIn, visit } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import percySnapshot from '@percy/ember';
import a11yAudit from 'ember-a11y-testing/test-support/audit';

import { setupApplicationTest } from 'cargo/tests/helpers';

import axeConfig from '../axe-config';
import setupMirage from '../helpers/setup-mirage';

module('Acceptance | /crates/:name/owners', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('listing crate owners', async function (assert) {
this.server.loadFixtures();
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/reverse-dependencies-test.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import { click, currentURL } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

import { visit } from '../helpers/visit-ignoring-abort';

module('Acceptance | /crates/:crate_id/reverse_dependencies', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

function prepare({ server }) {
let foo = server.create('crate', { name: 'foo' });
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/search-test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { blur, click, currentURL, fillIn, settled, triggerEvent, visit, waitFor } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import { defer } from 'rsvp';
Expand All @@ -9,13 +8,13 @@ import a11yAudit from 'ember-a11y-testing/test-support/audit';
import { keyDown } from 'ember-keyboard/test-support/test-helpers';
import { getPageTitle } from 'ember-page-title/test-support';

import { setupApplicationTest } from 'cargo/tests/helpers';

import { list as listCrates } from '../../mirage/route-handlers/crates';
import axeConfig from '../axe-config';
import setupMirage from '../helpers/setup-mirage';

module('Acceptance | search', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('searching for "rust"', async function (assert) {
this.server.loadFixtures();
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/team-page-test.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import { visit } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import percySnapshot from '@percy/ember';
import a11yAudit from 'ember-a11y-testing/test-support/audit';

import { setupApplicationTest } from 'cargo/tests/helpers';

import axeConfig from '../axe-config';
import setupMirage from '../helpers/setup-mirage';

module('Acceptance | team page', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('has team organization display', async function (assert) {
this.server.loadFixtures();
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/token-invites-test.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import { currentURL } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import percySnapshot from '@percy/ember';
import Response from 'ember-cli-mirage/response';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

import { visit } from '../helpers/visit-ignoring-abort';

module('Acceptance | /accept-invite/:token', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('visiting to /accept-invite shows 404 page', async function (assert) {
await visit('/accept-invite');
Expand Down
5 changes: 2 additions & 3 deletions tests/acceptance/user-page-test.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import { visit } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import percySnapshot from '@percy/ember';
import a11yAudit from 'ember-a11y-testing/test-support/audit';

import { setupApplicationTest } from 'cargo/tests/helpers';

import axeConfig from '../axe-config';
import setupMirage from '../helpers/setup-mirage';

module('Acceptance | user page', function (hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

test('has user display', async function (assert) {
this.server.loadFixtures();
Expand Down
5 changes: 2 additions & 3 deletions tests/bugs/2329-test.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import { click, currentURL, waitFor } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';
import { module, test } from 'qunit';

import window from 'ember-window-mock';
import { setupWindowMock } from 'ember-window-mock/test-support';

import setupMirage from '../helpers/setup-mirage';
import { setupApplicationTest } from 'cargo/tests/helpers';

import { visit } from '../helpers/visit-ignoring-abort';

module('Bug #2329', function (hooks) {
setupApplicationTest(hooks);
setupWindowMock(hooks);
setupMirage(hooks);

test('is fixed', async function (assert) {
let user = this.server.create('user');
Expand Down
3 changes: 2 additions & 1 deletion tests/components/crate-row-test.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { render } from '@ember/test-helpers';
import { setupRenderingTest } from 'ember-qunit';
import { module, test } from 'qunit';

import { hbs } from 'ember-cli-htmlbars';

import { setupRenderingTest } from 'cargo/tests/helpers';

import setupMirage from '../helpers/setup-mirage';

module('Component | CrateRow', function (hooks) {
Expand Down
Loading