CI: Disable yarn test command for embroider job
#3241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
disable-embroider
branch
from
f6abe2b to
5c23903
Compare
|
I'll take the liberty to merge this as is, since it's kinda blocking some of the other PRs and we're not actually using this CI job for anything right now anyway. @bors r+ |
|
📌 Commit 5c23903 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running into a similar issue to what is described at embroider-build/embroider#677. We currently allow the CI step to fail, but since it waits until it times out it keeps the PRs in "running" state for an unnecessarily long time.
This PR is changing the CI to only build, but not run the tests, with embroider to avoid the above issue. Once embroider-build/embroider#677 is addressed we can revert this change again.
r? @locks