-
Notifications
You must be signed in to change notification settings - Fork 645
Extract CrateSidebar
component
#3215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors r+ |
📌 Commit 6b8e09b has been approved by |
☔ The latest upstream changes (presumably #3222) made this pull request unmergeable. Please resolve the merge conflicts. |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
6b8e09b
to
48f7a8e
Compare
@bors r=locks |
📌 Commit 48f7a8e has been approved by |
Extract `CrateSidebar` component This will make it easier to potentially reuse it on other pages, like the version list page, and it also will make it easier to test this component in isolation :) r? `@pichfl`
💥 Test timed out |
48f7a8e
to
495c119
Compare
@bors r=locks |
📌 Commit 495c119 has been approved by |
☀️ Test successful - checks-actions |
This will make it easier to potentially reuse it on other pages, like the version list page, and it also will make it easier to test this component in isolation :)
r? @pichfl