Version|Crate: Replace encodable() methods
#3178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
encodable-version
branch
from
1518282 to
e585006
Compare
|
I've added a corresponding change for |
Turbo87
changed the title
encodable() methodencodable() method
Turbo87
changed the title
encodable() methodencodable() methods
|
@bors r+ |
|
📌 Commit bef2600 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to #3168 and brings us one step closer to removing the
models -> viewsdependency by inverting the relationship for theVersionmodel andEncodableVersionview.r? @pietroalbini