models::Dependency: Replace encodable() method
#3134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
encodable-dep
branch
4 times, most recently
from
bf09166 to
db76cfd
Compare
|
@bors r+ |
|
📌 Commit f79a463 has been approved by |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Jan 11, 2021
CrateOwnerInvitation: Replace `encodable()` method This PR is similar to #3134 and brings us one step closer to removing the `models -> views` dependency by inverting the relationship for the `CrateOwnerInvitation` model and `EncodableCrateOwnerInvitation` view. r? `@pietroalbini`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #3124 by implementing
from_dep()andfrom_reverse_dep()methods for theEncodableDependencystruct and removing theencodable()methods onDependencyandReverseDependency. We can't use theFromtrait in these cases because thecrate_namehas to be explicitly provided. What we could do instead is implementFrom<(Dependency, String)>, but that doesn't feel right to me.r? @pietroalbini