Skip to content

Update embroider to v0.34.0 #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Update embroider to v0.34.0 #3082

merged 1 commit into from
Dec 11, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 9, 2020

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@embroider/compat 0.33.0 -> 0.34.0 age adoption passing confidence
@embroider/core 0.33.0 -> 0.34.0 age adoption passing confidence
@embroider/webpack 0.33.0 -> 0.34.0 age adoption passing confidence

Release Notes

embroider-build/embroider

v0.34.0

Compare Source

  • ENHANCEMENT: add publicAssetURL option to @embroider/webpack to support CDN deploys (the built-in webpack options for this didn't let you manipulate your index.html, since we take care of that directly in @embroider/webpack).
  • COMPAT: update @embroider/util to follow internal refactoring on ember canary.
  • HOUSEKEEPING: broccoli-related dependency updates
  • DOCS: split the "Replacing the Component Helper" guide into its own document and expanded the use cases.

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @smarnach (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors
Copy link
Contributor

bors commented Dec 10, 2020

☔ The latest upstream changes (presumably #3086) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@renovate renovate bot force-pushed the renovate/embroider branch from ca29138 to c0c6dd6 Compare December 10, 2020 23:35
@Turbo87
Copy link
Member

Turbo87 commented Dec 11, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Dec 11, 2020

📌 Commit c0c6dd6 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Dec 11, 2020

⌛ Testing commit c0c6dd6 with merge e4488b0...

@bors
Copy link
Contributor

bors commented Dec 11, 2020

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing e4488b0 to master...

@bors bors merged commit e4488b0 into master Dec 11, 2020
@renovate renovate bot deleted the renovate/embroider branch December 11, 2020 17:06
@bors bors mentioned this pull request Dec 11, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants