Skip to content

tests/util: Remove unused BackgroundJob struct #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 4, 2020

This struct does not appear to be used anywhere (anymore).

r? @JohnTitor

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reasonable and all the tests actually pass. And if we need this, then we should export it from swirl anyway.

cc @jtgeibel just in case.

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 5, 2020

📌 Commit 823c81c has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Dec 5, 2020

⌛ Testing commit 823c81c with merge b0d4dc4...

@bors
Copy link
Contributor

bors commented Dec 5, 2020

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing b0d4dc4 to master...

@bors bors merged commit b0d4dc4 into rust-lang:master Dec 5, 2020
@Turbo87 Turbo87 deleted the bg-jobs branch December 5, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants