models/version: Add tests for Version::top() function
#3067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
top-version-tests
branch
2 times, most recently
from
786385f to
bc898ad
Compare
Turbo87
force-pushed
the
top-version-tests
branch
from
bc898ad to
62d86ea
Compare
Turbo87
force-pushed
the
top-version-tests
branch
from
62d86ea to
ad10cdd
Compare
|
@bors r+ |
|
📌 Commit ad10cdd has been approved by |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Jan 5, 2021
Clean up `TopVersions` code This PR cleans up the code that figures out the `highest` and `newest` versions of a crate in several ways. I hope that the commit list gives enough context on the individual changes. Primarily, this decouples the code from the `Version` struct, and it moves the `0.0.0` defaulting to the `encodable()` method of the `Krate` model, instead of performing that in the low-level code directly. Like #3067, this PR is also in preparation for resolving #2710. r? `@jtgeibel`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this can be tested through API tests it's much more convenient to have a unit tests for this functionality.
This PR is in preparation for fixing #2710, by introducing a
max_stable_versionproperty on thecrateresource.r? @jtgeibel