crate.version: Fix latestUnyankedVersion bug
#2894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`latestStableVersion` is already guaranteed to be `null` because of the previous condition. I assume the original intention here was to check for `latestUnyankedVersion` instead.
Turbo87
added
A-frontend 🐹
C-bug 🐞
|
Good catch. @bors r+ |
|
📌 Commit 66a1cc4 has been approved by |
|
☀️ Test successful - checks-travis |
jtgeibel
added a commit
to jtgeibel/crates.io
that referenced
this pull request
Oct 29, 2020
It looks like fixing the bug in rust-lang#2894 exposed this bug. When there are only pre-release versions of a crate, the version number needs to be extracted so that the version object can be located again a few lines later. This could probably be refactored, but for now this removes the spurious error notification shown in the UI.
bors
added a commit
that referenced
this pull request
Oct 29, 2020
Fix version logic when there are only pre-releases It looks like fixing the bug in #2894 exposed this bug. When there are only pre-release versions of a crate, the version number needs to be extracted so that the version object can be located again a few lines later. This could probably be refactored, but for now this removes the spurious error notification shown in the UI. r? `@Turbo87`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latestStableVersionis already guaranteed to benullbecause of the previous condition. I assume the original intention here was to check forlatestUnyankedVersioninstead.It looks like this bug was already present in the original implementation in #1857
r? @jtgeibel