Skip to content

Add weights to search query #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jespino
Copy link
Contributor

@jespino jespino commented Mar 14, 2016

This give weight to the fields and I think must fix the #281 issue.

@alexcrichton
Copy link
Member

I believe in theory this is what the setweight calls were trying to do in the migrations. Now knowing basically nothing about postgres full text search, maybe that's wrong? Seems though that we should rely on the weights that are indexed?

@jespino
Copy link
Contributor Author

jespino commented Mar 14, 2016

Yes you are right, I have rereaded the postgresql documentation and the default values looks ok, but then I don't understand why is exact match name isn't the first result normally.

@jespino jespino closed this Mar 14, 2016
@jespino
Copy link
Contributor Author

jespino commented Mar 14, 2016

There are cases where the full-text search have strange behavior, cargo- have the same score than cargo (I think we can add something like ORDER crates.name == q) to ensure that if any exact match happens have precedence over not exact matches.

bors added a commit that referenced this pull request Dec 18, 2019
…0.9, r=Turbo87

Bump ember-exam from 1.0.0 to 4.0.9

[//]: # (dependabot-start)
⚠️  **Dependabot is rebasing this PR** ⚠️

If you make any changes to it yourself then they will take precedence over the rebase.

---

[//]: # (dependabot-end)

Bumps [ember-exam](https://github.com/ember-cli/ember-exam) from 1.0.0 to 4.0.9.
<details>
<summary>Release notes</summary>

*Sourced from [ember-exam's releases](https://github.com/ember-cli/ember-exam/releases).*

> ## v4.0.6 - Bug Fix for Process Object Validation, Enhancement for 'write-module-metadata' feature, & Update Dependencies
> - Ensure process object is valid before registering callbacks for process.on and process.error.
> - Update Dependencies
>
> ## v4.0.4 Validate if testem object is available
> - v4.0.3 introduces an error `Cannot read property 'emit' of undefined` due to testem object is unavailable during ebmer serve. The version v4.0.4 includes a fix for v4.0.3.
>
> ## v4.0.3 Introducing write-module-metadata-file command
> * Adding `write-module-metadata-file` to generate test module data after execution. [#265](https://github-redirect.dependabot.com/ember-cli/ember-exam/issues/265)
> * Update Dependencies
>
> ## v4.0.2 - Fix bug in --write-execution-file for failedBrowsers Array
> - ensure browserExitHandler is called for global errors [#362](https://github-redirect.dependabot.com/ember-cli/ember-exam/issues/362)
>
> ## 4.0.1 - Improve complete browser book keeping & improve request next module conditions
> - Improve complete browser book keeping & improve request next module conditions [#357](https://github-redirect.dependabot.com/ember-cli/ember-exam/issues/357)
>
> ## 4.0.0 - Bump node support version to >=8
> - Update to use node version >= 8 [#308](https://github-redirect.dependabot.com/ember-cli/ember-exam/issues/308)
> - Throw error when there are no matching tests with a given input by `file-path` and `module-path` [#302](https://github-redirect.dependabot.com/ember-cli/ember-exam/issues/302)
> - Update Dependencies
>
> ## 3.0.3 - Introducing file-path & module-path commands & Update Dependencies
> - Adding `file-path` and `module-path` commands for improved test startup time [#266](https://github-redirect.dependabot.com/ember-cli/ember-exam/issues/266) & [#300](https://github-redirect.dependabot.com/ember-cli/ember-exam/issues/300)
> - Update Dependencies
>
> ## 3.0.2 - Docs updates & Update Dependencies & graceful exit when async iterator fails
> - Docs updates [#286](https://github-redirect.dependabot.com/ember-cli/ember-exam/issues/286) [#285](https://github-redirect.dependabot.com/ember-cli/ember-exam/issues/285)
> - Update Dependencies
> - Graceful exit when async iterator fails [#274](https://github-redirect.dependabot.com/ember-cli/ember-exam/issues/274)
</details>
<details>
<summary>Changelog</summary>

*Sourced from [ember-exam's changelog](https://github.com/ember-cli/ember-exam/blob/master/CHANGELOG.md).*

> v4.0.9 / 2019-12-05
> ===================
> * [Enhancement] Add a number of total tests, failed tests, passed tests, and skipped tests to a module metadata file ([@&#8203;choheekim](https://github.com/choheekim))
> * [Enhancement] Update README.md corresponding to changes in the module metadata file contents ([@&#8203;choheekim](https://github.com/choheekim))
> * [BugFix] Update yarn.lock to use latest version of core-js-compat (v.3.4.7) ([@&#8203;choheekim](https://github.com/choheekim))
> * [BugFix] Fix process validation when registering callbacks for process.error & process.exit ([@&#8203;choheekim](https://github.com/choheekim))
> * Bump ember-template-lint from 1.6.0 to 1.6.1 <dependabot[bot]>
> * Bump ember-qunit from 4.5.1 to 4.6.0 <dependabot[bot]>
> * Bump eslint-plugin-ember from 7.2.0 to 7.3.0 <dependabot[bot]>
> * Bump ember-load-initializers from 2.1.0 to 2.1.1 <dependabot[bot]>
> * Bump ember-template-lint from 1.6.1 to 1.8.1 <dependabot[bot]>
> * Bump ember-source from 3.13.3 to 3.14.1 <dependabot[bot]>
> * Bump chalk from 2.4.2 to 3.0.0 <dependabot[bot]>
> * Bump ember-export-application-global from 2.0.0 to 2.0.1 <dependabot[bot]>
> * Bump ember-template-lint from 1.8.1 to 1.8.2 <dependabot[bot]>
> * Bump ember-cli from 3.13.1 to 3.14.0 <dependabot[bot]>
> * Bump ember-resolver from 5.3.0 to 6.0.0  <dependabot[bot]>
> * Bump ember-cli-babel from 7.12.0 to 7.13.0 <dependabot[bot]>
> * Bump execa from 3.3.0 to 3.4.0 <dependabot[bot]>
> * Bump ember-source from 3.14.2 to 3.14.3 <dependabot[bot]>
> * Bump ember-template-lint from 1.8.2 to 1.9.0 <dependabot[bot]>
> * Bump ember-cli-htmlbars from 4.0.8 to 4.0.9 <dependabot[bot]>
>
>
> v4.0.5 / 2019-10-25
> ===================
> * [BugFix] Validate process object is defined when registering event callbacks for process.error & process.exit ([@&#8203;choheekim](https://github.com/choheekim))
> * [BugFix] Updates page title for dummy app to "Ember Exam" ([@&#8203;howie](https://github.com/howie))
> * Bump rimraf from 2.7.1 to 3.0.0 <dependabot[bot]>
> * Bump ember-cli from 3.12.0 to 3.13.1 <dependabot[bot]>
> * Bump ember-cli-deploy-build from 1.1.1 to 2.0.0 <dependabot[bot]>
> * Bump mocha from 6.2.0 to 6.2.2 <dependabot[bot]>
> * Bump ember-template-lint from 1.5.3 to 1.6.0 <dependabot[bot]>
> * Bump ember-cli-babel from 7.11.1 to 7.12.0 <dependabot[bot]>
> * Bump ember-cli-inject-live-reload from 2.0.1 to 2.0.2 <dependabot[bot]>
> * Bump @ember/optional-features from 1.0.0 to 1.1.0  <dependabot[bot]>
> * Bump ember-cli-addon-docs from 0.6.14 to 0.6.15 <dependabot[bot]>
> * Bump ember-cli-htmlbars-inline-precompile from 2.1.0 to 3.0.1 <dependabot[bot]>
> * Bump ember-source from 3.10.2 to 3.13.3 <dependabot[bot]>
> * Bump eslint-plugin-node from 8.0.1 to 10.0.0  <dependabot[bot]>
> * Bump @ember/optional-features from 0.7.0 to 1.0.0 <dependabot[bot]>
> * Bump ember-cli-htmlbars from 3.1.0 to 4.0.8 <dependabot[bot]>
> * Bump eslint-plugin-ember from 6.10.1 to 7.2.0 <dependabot[bot]>
>
>
> v4.0.4 / 2019-09-30
> ===================
> * [BugFix] Validate testem object is defined ([@&#8203;choheekim](https://github.com/choheekim))
> * Bump ember-cli-babel from 7.11.0 to 7.11.1 <dependabot[bot]>
>
></tr></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`ca30c3e`](ember-cli/ember-exam@ca30c3e) 4.0.9
- [`29ac2d6`](ember-cli/ember-exam@29ac2d6) Update changelog for v4.0.9
- [`b8efb9f`](ember-cli/ember-exam@b8efb9f) Merge pull request [#439](https://github-redirect.dependabot.com/ember-cli/ember-exam/issues/439) from choheekim/update-readme
- [`040299d`](ember-cli/ember-exam@040299d) Add skipped tests number in test module metadata and update readme
- [`73fb045`](ember-cli/ember-exam@73fb045) Update README reflecting to current changes in module-metadata-file
- [`417f7e0`](ember-cli/ember-exam@417f7e0) Bump ember-template-lint from 1.8.2 to 1.9.0
- [`4b2d46a`](ember-cli/ember-exam@4b2d46a) Bump ember-cli-htmlbars from 4.0.8 to 4.0.9
- [`c5116fd`](ember-cli/ember-exam@c5116fd) Bump ember-source from 3.14.2 to 3.14.3
- [`ad8905b`](ember-cli/ember-exam@ad8905b) Update changelog for v4.0.8
- [`f3acfee`](ember-cli/ember-exam@f3acfee) Release v4.0.8
- Additional commits viewable in [compare view](ember-cli/ember-exam@v1.0.0...v4.0.9)
</details>
<details>
<summary>Maintainer changes</summary>

This version was pushed to npm by [choheekim](https://www.npmjs.com/~choheekim), a new releaser for ember-exam since your current version.
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-exam&package-manager=npm_and_yarn&previous-version=1.0.0&new-version=4.0.9)](https://dependabot.com/compatibility-score.html?dependency-name=ember-exam&package-manager=npm_and_yarn&previous-version=1.0.0&new-version=4.0.9)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
bors added a commit that referenced this pull request Sep 28, 2020
… r=Turbo87

Update dependency ember-cli-notifications to v6.3.1

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ember-cli-notifications](https://togithub.com/mansona/ember-cli-notifications) | devDependencies | patch | [`6.3.0` -> `6.3.1`](https://renovatebot.com/diffs/npm/ember-cli-notifications/6.3.0/6.3.1) |

---

### Release Notes

<details>
<summary>mansona/ember-cli-notifications</summary>

### [`v6.3.1`](https://togithub.com/mansona/ember-cli-notifications/blob/master/CHANGELOG.md#&#8203;631--2020-09-28)

[Compare Source](https://togithub.com/mansona/ember-cli-notifications/compare/v6.3.0...v6.3.1)

==================

-   FIX: Merge pull request [#&#8203;287](https://togithub.com/mansona/ember-cli-notifications/issues/287) from jacobq/remove-getWithDefault [`#286`](https://togithub.com/mansona/ember-cli-notifications/issues/286)

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants