Display teams on the crate owners page #2253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the crate owners page (`/crates/<crate-name>/owners`) to display teams which are set to be crate owner. It also adds a "Remove" button for each team which allows removing teams from owning the crate in the same way that user type owners can be removed. Addresses rust-lang#1617.
|
r? @smarnach (rust_highfive has picked a reviewer for you, use r? to override) |
|
@locks Could you take this review? I'm too slow at frontend reviews to find time for them at the moment. For what it's worth, in principle I'm in favour of adding this feature. |
locks
suggested changes
Mar 12, 2020
locks
approved these changes
Mar 12, 2020
|
@bors r+ |
|
📌 Commit 12fbdb6 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the crate owners page (
/crates/<crate-name>/owners) to display teams which are set to be crate owner. It also adds a "Remove" button for each team which allows removing teams from owning the crate in the same way that user type owners can be removed.I have displayed the team as
<organisation>/<team>rather thangithub:<organisation>:<team>because I think it looks cleaner (egrust-lang/corevsgithub:rust-lang:core). Happy to change it if people disagree.I haven't touched adding teams via the owners page in this PR. From what I can tell, it is currently possible although the message that is returned is misleading. I think that should be tackled in a separate PR.
Addresses #1617.