Revert #2201 to fix broken new token button #2211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works fine on staging. Deploy to production in process. @bors r+ |
|
📌 Commit 0371441 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've bisected the issue with the broken "New Token" button to the merge of #2201. That PR bumps
ember-sourcefrom 3.16.1 to 3.16.2.What is very strange is that the original commit 28a03bf that implemented the change does not appear to have this issue. Therefore it seems the issue is some sort of conflict between multiple pull requests somewhere in c970817...663259c.
I'm deploying to staging now and will deploy to production as soon as I test the change there.
cc @locks
r? @ghost