Skip to content

Replace tempdir with tempfile #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

Replace tempdir with tempfile #2186

merged 1 commit into from
Feb 13, 2020

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Feb 13, 2020 •
edited
Loading

replaces tempdir which is deprecated with tempfile

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jtgeibel
Copy link
Member

@JohnTitor thanks for the PR! Would you drop the last 2 commits of this series and scope this to just on the change to tempfile? Unfortunately we cannot merge a full-scale update to the lockfile at this time.

r? @jtgeibel

@rust-highfive rust-highfive assigned jtgeibel and unassigned sgrif Feb 13, 2020
@JohnTitor
Copy link
Member Author

Sure, dropped!

@JohnTitor JohnTitor changed the title Clean up dependencies Replace tempdir with tempfile Feb 13, 2020
@locks
Copy link
Contributor

locks commented Feb 13, 2020

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 13, 2020

📌 Commit b5f347d has been approved by locks

@bors
Copy link
Contributor

bors commented Feb 13, 2020

⌛ Testing commit b5f347d with merge eaf78af...

bors added a commit that referenced this pull request Feb 13, 2020
@bors
Auto merge of #2186 - JohnTitor:use-tempfile, r=locks
eaf78af 
Replace `tempdir` with `tempfile`

replaces `tempdir` which is deprecated with `tempfile`
@bors
Copy link
Contributor

bors commented Feb 13, 2020

☀️ Test successful - checks-travis
Approved by: locks
Pushing eaf78af to master...

@bors bors merged commit b5f347d into rust-lang:master Feb 13, 2020
@bors bors mentioned this pull request Feb 13, 2020
Merged
7 tasks
@JohnTitor JohnTitor deleted the use-tempfile branch February 13, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jtgeibel jtgeibel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JohnTitor @rust-highfive @jtgeibel @locks @bors @sgrif