Revert status badge to travis #2184
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jtgeibel (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # crates.io | |||
|
|
|||
| [](https://github.com/rust-lang/crates.io/actions?query=workflow%3ACI) | |||
| [](https://github.com/rust-lang/crates.io/actions?query=workflow%3ACI) | |||
There was a problem hiding this comment.
This should probably point to the master branch (which should be the default), since bors does its testing on auto.
There was a problem hiding this comment.
But we don't run any Actions on master, right? Actually we use same queries in Clippy: rust-lang/rust-clippy@fb59043
There was a problem hiding this comment.
We do run against master, but in the Actions UI it shows as auto (with a link for "other workflows run on this commit"). The commit message you link to seems to indicate that this isn't just an issue with the UI, but also with the status badges. Do you know if we've actually seen this report incorrect status for our repo in the past? It seems like the downside to this change is that we will show a build failure if a bors merge fails on auto and thus never makes it to master.
Since we don't gate on GH Actions currently, maybe it makes sense to revert back to displaying the Travis badge until we resolve everything in #2059. (I'll add a note about this there as well.)
There was a problem hiding this comment.
Do you know if we've actually seen this report incorrect status for our repo in the past?
IIRC default link sometimes shows unexpected workflows but I have no reference :/
Since we don't gate on GH Actions currently, maybe it makes sense to revert back to displaying the Travis badge until we resolve everything in #2059. (I'll add a note about this there as well.)
I feel it makes sense. Would you mind me doing so in this PR?
There was a problem hiding this comment.
I feel it makes sense. Would you mind my doing so in this PR?
Sounds fine to me 👍
JohnTitor
force-pushed
the
specify-branch
branch
from
1b358c9 to
32dbdb3
Compare
JohnTitor
changed the title
|
Great! @bors r+ |
|
📌 Commit 32dbdb3 has been approved by |
Revert status badge to travis ~~Prevents unexpected failures from being displayed.~~ Since we don't gate on GH Actions currently, so display the Travis badge until we resolve everything in #2059.
|
☀️ Test successful - checks-travis |
Prevents unexpected failures from being displayed.Since we don't gate on GH Actions currently, so display the Travis badge until we resolve everything in #2059.