Skip to content

Use a modern font stack inspired by Bootstrap 4 #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

Calinou
Copy link
Contributor

@Calinou Calinou commented Jan 17, 2020

This makes the frontend use a better-looking, more consistent font stack.

Preview

Note: The font used depends on the OS (as before). Screenshots below were taken on Fedora 31 with Microsoft fonts installed.

Before

Before

After

After

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @smarnach (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Calinou
Copy link
Contributor Author

Calinou commented Feb 15, 2020

Is there anything I can do to help this get merged? I can notice some CI failures below, but I'm not sure if they're related to my PR.

@JohnTitor
Copy link
Member

JohnTitor commented Feb 16, 2020

@Calinou IIRC it's a known issue and should be fixed in latest nightly, so unrelated. If you want to re-trigger CI, you can rebase or close/re-open the PR.

@Calinou Calinou force-pushed the use-modern-font-stack branch from fd8c089 to aaf62aa Compare February 16, 2020 21:53
@Calinou
Copy link
Contributor Author

Calinou commented Mar 8, 2020

Can I update the Percy screenshots on my own to make the visual regression tests pass, or does someone else have to do it?

@jtgeibel
Copy link
Member

jtgeibel commented Mar 9, 2020

@Calinou I've approved the visual changes in Percy. Lets go ahead and merge, sorry for the delay.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2020

📌 Commit aaf62aa has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Mar 9, 2020

⌛ Testing commit aaf62aa with merge 527c8dd...

@bors
Copy link
Contributor

bors commented Mar 9, 2020

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing 527c8dd to master...

@bors bors merged commit 527c8dd into rust-lang:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants