Skip to content

Remove obsolete ember-component-attributes dependency #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 3, 2020

We are using Angle Bracket Component syntax now, which makes this dependency obsolete. In fact, we no longer use the html-attributes helper anywhere at all, so this should be safe to just remove.

r? @locks

We are using Angle Bracket Component syntax now, which makes this dependency obsolete. In fact, we no longer use the `html-attributes` helper anywhere at all, so this should be safe to just remove.
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+

@locks
Copy link
Contributor

locks commented Jan 3, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jan 3, 2020

📌 Commit c981dee has been approved by locks

bors added a commit that referenced this pull request Jan 3, 2020
Remove obsolete `ember-component-attributes` dependency

We are using Angle Bracket Component syntax now, which makes this dependency obsolete. In fact, we no longer use the `html-attributes` helper anywhere at all, so this should be safe to just remove.

r? @locks
@bors
Copy link
Contributor

bors commented Jan 3, 2020

⌛ Testing commit c981dee with merge b308ac8...

@bors
Copy link
Contributor

bors commented Jan 3, 2020

☀️ Test successful - checks-travis
Approved by: locks
Pushing b308ac8 to master...

@bors bors merged commit c981dee into rust-lang:master Jan 3, 2020
@Turbo87 Turbo87 deleted the ember-component-attributes branch March 30, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants