Fix an icon link that was generating bad URLs #2045
Conversation
On current staging, but not production, navigating directly to a path such as `/crates/crate-name` results in a request sent to `/crates/cargo-835dd6a18132048a52ac569f2615b59d.png` (a 404 response status). It appears that the `src` field is now treated as a relative path. Using an absolute URL works for me locally.
|
I've pushed this to staging and this issue is gone there. I've also noticed that navigating directly to a crate or version page results in a spinner in place of the follow button. For example: https://staging.crates.io/crates/egg-man Things work after navigating within the app. It seems no request is sent to the backend endpoint when navigating directly. |
|
I assume this is related to zonkyio/ember-web-app#144, which got merged in #2002. I'm wondering though if this is the correct resolution or if the image actually should be fingerprinted. I'll have a look. |
|
Since https://zonkyio.github.io/ember-web-app/docs/manifest/available-properties#icons is also using absolute paths I'll go ahead and merge this 👍 @bors r+ |
|
📌 Commit b3aac9b has been approved by |
Fix an icon link that was generating bad URLs On current staging, but not production, navigating directly to a path such as `/crates/crate-name` results in a request sent to `/crates/cargo-835dd6a18132048a52ac569f2615b59d.png` (a 404 response status). It appears that the `src` field is now treated as a relative path. Using an absolute URL works for me locally. r? @Turbo87
|
☀️ Test successful - checks-travis |
|
@Turbo87 from what I've seen, these files do end up hashed in production. I think we were good as of #1741, unless we've regressed somewhere. For instance, |
|
yep, saw that when I was trying out your branch locally :) |
On current staging, but not production, navigating directly to a path
such as
/crates/crate-nameresults in a request sent to/crates/cargo-835dd6a18132048a52ac569f2615b59d.png(a 404 responsestatus).
It appears that the
srcfield is now treated as a relative path.Using an absolute URL works for me locally.
r? @Turbo87