Replace <XSelect> component with regular <select> element
#2037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could also consider using https://github.com/jmurphyau/ember-truth-helpers instead if we start to use this more and/or need other, related helpers
| @@ -0,0 +1,7 @@ | |||
| import { helper } from '@ember/component/helper'; | |||
There was a problem hiding this comment.
it's gonna be so good to have this helper as part of the framework :)
NullVoxPopuli
approved these changes
Dec 21, 2019
|
@bors r+ |
|
📌 Commit 8e1714b has been approved by |
bors
added a commit
that referenced
this pull request
Dec 21, 2019
Replace `<XSelect>` component with regular `<select>` element We've only been using `XSelect` in one specific place and v3 of the addon was causing deprecation warnings due to their use of the `this.$()` API. Since we were not using any of the more advanced features from `XSelect` it was relatively straight-forward to replace with just a regular `<select>` element. r? @locks
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've only been using
XSelectin one specific place and v3 of the addon was causing deprecation warnings due to their use of thethis.$()API.Since we were not using any of the more advanced features from
XSelectit was relatively straight-forward to replace with just a regular<select>element.r? @locks