Remove license column on crates table
#1815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sgrif (rust_highfive has picked a reviewer for you, use r? to override) |
rye
changed the title
license column on crateslicense column on crates table
sgrif
approved these changes
Aug 29, 2019
This is a big change! `cargo check` says this is fine, but some manual verification and testing is probably a good idea. (`cargo test` does pass locally for me, but that only tells half the story.) As part of (GitHub) #736, this commit not only removes the commitment of license information into the database, but it also removes the handling in the controller. For silent backwards compatibility, it might be better to simply drop the license field, for example if it's being uploaded by outdated clients. I am not sure, however, and will probably need feedback on this. (A commit running `cargo fmt` was also rebased into this one.) Signed-off-by: Kristofer Rye <[email protected]>
This is a destructive migration! It might be best to deploy it independently of its parent. Signed-off-by: Kristofer Rye <[email protected]>
|
@sgrif, thanks! The rebase has been pushed… I merged the |
|
Thank you! This looks fine, but I'm going to hold off on merging until tomorrow so I can deploy it immediately after since this contains destructive migrations. |
|
@bors: r+ |
|
📌 Commit 37bd286 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 5, 2019
Remove `license` column on `crates` table Seemingly the last step in the checklist on #736, this PR removes the `license` column on the `crates` table, and all references thereto. (In fact, I think #736 can be closed once this PR is merged.) As of #803, the front-end no longer really used this field, and the front-end was also changed to render the license of the _current_ version, instead of the value coming from this now-obsolete `license` column on the crate. Thus, this column likely contains stale data and, to my knowledge, isn't changed at all when a new version is uploaded. I wasn't sure what requirements are enforced for backwards-compatibility, or whether my changes here would actually affect behavior of e.g. if there are old versions of `cargo` that will upload with these values. I am happy for these changes to be scrutinized until this is verified to be safe.
|
☀️ Test successful - checks-travis |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemingly the last step in the checklist on #736, this PR removes the
licensecolumn on thecratestable, and all references thereto. (In fact, I think #736 can be closed once this PR is merged.)As of #803, the front-end no longer really used this field, and the front-end was also changed to render the license of the current version, instead of the value coming from this now-obsolete
licensecolumn on the crate. Thus, this column likely contains stale data and, to my knowledge, isn't changed at all when a new version is uploaded.I wasn't sure what requirements are enforced for backwards-compatibility, or whether my changes here would actually affect behavior of e.g. if there are old versions of
cargothat will upload with these values. I am happy for these changes to be scrutinized until this is verified to be safe.