Fix assertion error in Ember for version downloads #1728
Conversation
Fix the following assertion error that occurs when running the frontend in debug mode, which cause graphs to not display at all. > Assertion Failed: You must include an 'id' for version-download in an > object passed to 'push' This has been happening since 3c92ca2 landed. The fix involves telling Ember how to create a unique ID for a version-download object, using the composite key. I haven't been able to confirm, but I believe this is the reason that graphs in production are only ever counting/displaying a single version. When using this change locally in debug mode against the live website, the downloads graphs are rendering correctly. Fixes rust-lang#1704.
bryanburgers
force-pushed
the
fix-ember-assertion-error
branch
from
8f6390c to
4b6685e
Compare
|
Looks good to me. Can we write tests around the serializers? How about testing |
|
@kzys I agree that having tests for this would be a good idea. I'm not sure that unit testing the serializer is the best approach though. Maybe we can find a way to acceptance-test this to make sure that it works from end-to-end. (well, without the actual backend though...) |
|
Until we have the way to write end-to-end tests, I'd like to keep some tests against this serializer. Having unit tests helps us to identify root causes quickly, while it tends to couple with the implementation. |
|
I don’t typically write much Ember, and I didn’t see any existing tests testing serializers that I could use an example. I’d welcome some advice on how to add useful tests to this! |
|
I agree it'd be great to add more end-to-end tests here, but getting that set up is a large enough task for its own PR. I've confirmed this does fix a major UI bug locally, so I'm going to merge this. @bors: r+ |
|
📌 Commit 4b6685e has been approved by |
Fix assertion error in Ember for version downloads Fix the following assertion error that occurs when running the frontend in debug mode, which cause graphs to not display at all. > Assertion Failed: You must include an 'id' for version-download in an object passed to 'push' This has been happening since 3c92ca2 landed. The fix involves telling Ember how to create a unique ID for a version-download object, using the composite key. I haven't been able to confirm, but I believe this is the reason that graphs in production are only ever counting/displaying a single version. When using this change locally in debug mode against the live website, the downloads graphs are rendering correctly. Fixes #1704.
|
☀️ Test successful - checks-travis |
Fix the following assertion error that occurs when running the frontend in debug mode, which cause graphs to not display at all.
This has been happening since 3c92ca2 landed.
The fix involves telling Ember how to create a unique ID for a version-download object, using the composite key.
I haven't been able to confirm, but I believe this is the reason that graphs in production are only ever counting/displaying a single version. When using this change locally in debug mode against the live website, the downloads graphs are rendering correctly.
Fixes #1704.