Move the background jobs to another crate #1661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #1657) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I merged to resolve the merge conflicts so that I could r+ this, but it looks like the lockfile isn't storing the git SHA and the new build is picking up the latest changes on |
I wrote this code intending to extract it, and I'm planning to release it after a few more changes which aren't relevant to crates.io. The code right now is largely the same as what was here before, the main difference being the use of a different error type. The error handling will probably churn some more in the near future as I figure out what I want the error handling story to look like in that crate
sgrif
force-pushed
the
sg-move-background-jobs-to-separate-crate
branch
from
a0258b2 to
438ba40
Compare
|
Locked to a single commit. @bors r=jtgeibel |
|
📌 Commit 438ba40 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 14, 2019
…, r=jtgeibel Move the background jobs to another crate I wrote this code intending to extract it, and I'm planning to release it after a few more changes which aren't relevant to crates.io. The code right now is largely the same as what was here before, the main difference being the use of a different error type. The error handling will probably churn some more in the near future as I figure out what I want the error handling story to look like in that crate
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this code intending to extract it, and I'm planning to release
it after a few more changes which aren't relevant to crates.io. The code
right now is largely the same as what was here before, the main
difference being the use of a different error type.
The error handling will probably churn some more in the near future as I
figure out what I want the error handling story to look like in that
crate