Add UI for sorting my crates by recent downloads

[jonhoo]

This fixes #1231, and renames "Downloads" to "All-Time Downloads" to be consistent with the sort dropdowns on other listings.

[carols10cents]

Thanks! I think this is almost there. I know this is hard to test because there isn't a way to log in when you're running npm run start:live, so you have to set up a backend and all that.

But when I was running this PR locally, when I go to /me/crates and then switch the sort to "All-Time Downloads", the closed dropdown says "Downloads", and if I switch to "Recent Downloads" the closed dropdown says "Alphabetical".

That's because the closed dropdown displays the value in currentSortBy, which comes from this function in controllers/me/crates.js, and that function only knows about "Downloads" and "Alphabetical". That function needs to change to look more like the other controllers, such as controllers/crates.js.

We're likely doing something wrong to end up with all this duplication (and it's been this way for a while), but I'm not sure the best way to fix the problem especially because while most of the sort dropdowns are the same, they aren't all the same (search result lists have "relevance" as an option).

So would you be willing to make the easy fix of updating the currentSortBy function in app/controllers/me/crates.js? Or would you like me to take care of it? It's no problem, just let me know!

[jonhoo]

Fixed in a1eacf4! Thanks for the detailed instructions :)

Wouldn't it be possible to have the same sort be used everywhere, and then override it specifically on the search results page (which should presumably be the only one that differs)?

[carols10cents]

Thank you, this works great now!!

bors: r+

Wouldn't it be possible to have the same sort be used everywhere, and then override it specifically on the search results page (which should presumably be the only one that differs)?

Yep, it's certainly possible, and doing so would fix #9. There might be other places that are different, I'm not sure!

[bors-voyager]

Build succeeded

• continuous-integration/travis-ci/push

[jonhoo]

The waiting-on-author label should probably be removed. Also, how/when do merged PRs show up on crates.io?

[carols10cents]

Just deployed, this is live now :)

I don't usually bother removing status labels from merged PRs, I only use those when looking at open PRs, so the label hanging around is fine :)