Gh login cant be unique #1109
Merged
Gh login cant be unique #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have no effect on production.
This is the latest user that crates.io knows about with this username.
carols10cents
force-pushed
the
gh_login_cant_be_unique
branch
from
fa0b577 to
40ca32d
Compare
sgrif
reviewed
Oct 8, 2017
| -- Its sole purpose is to fix the local database of anyone who ran 2017-09-26-200549 locally-- | ||
| -- that migration can't be run on production because lower(gh_login) isn't unique on production. | ||
|
|
||
| CREATE INDEX IF NOT EXISTS index_users_gh_login ON users (gh_login); |
There was a problem hiding this comment.
We still want this index to be on the lowercase name though, don't we? Should we have another migration that is along the lines of:
DROP INDEX index_users_gh_login;
CREATE INDEX lower_gh_login ON users (lower(gh_login));
carols10cents
force-pushed
the
gh_login_cant_be_unique
branch
from
05e7b81 to
e691e75
Compare
|
hows about now @sgrif ? |
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Oct 9, 2017
1109: Gh login cant be unique r=sgrif So I can't deploy to production right now because of the unique index added to users.gh_login. The values on production for gh_login aren't unique, and here's why: - Someone can sign up for github with username whatever. - They can sign in to crates.io. We now get their gh_id, say, 3 (which *is* unique) and their gh_login, whatever. Their user account gets crates.io id 10. - They rename or delete their github account, which leaves the username 'whatever' available again. (If they renamed their github account, their gh_id stays stable and we'd migrate their account to their new username next time they log in) - Someone else signs up for github with username wHaTeVeR. - They can sign in to crates.io. We now get their gh_id, 9000, and their gh_login, wHaTeVeR. Their user account gets crates.io id 10000. We can't get rid of the first whatever account, because they might sign in again with a renamed account but the same id, and they should be able to still access the crates they own and all that. All we know is that the account with the latest crates.io id for that lower(gh_login) is the last valid account we know of for that username (and should match the account that you click through to github, as long as they haven't renamed or deleted their github account since). r? @sgrif
Build succeeded |
This was referenced Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I can't deploy to production right now because of the unique index added to users.gh_login.
The values on production for gh_login aren't unique, and here's why:
We can't get rid of the first whatever account, because they might sign in again with a renamed account but the same id, and they should be able to still access the crates they own and all that.
All we know is that the account with the latest crates.io id for that lower(gh_login) is the last valid account we know of for that username (and should match the account that you click through to github, as long as they haven't renamed or deleted their github account since).
r? @sgrif