-
Notifications
You must be signed in to change notification settings - Fork 643
Resolves #1031 - Branding updates for crates.io #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, @seanprashad. The change looks good, but I think we better check something before landing, based on my experience from changing the tagline in the header. The current text, "The Rust community’s crate host", fits one line in most views/browsers. Since "registry" is a wider word than "host" (regularly), I think we want to check if the new sentence also fits in one line. I just made the change using Developer Tools in my browser and it still fits one line. Would you double-check that on your side, so we don't have to patch it again if it doesn't fit. (If it doesn't fit in one line, we need to reduce the size of the text a bit.) |
Thanks for that heads up @behnam - I'm not sure how to go about using Developer Tools in my browser to view/modify the font size/placement, or to actually run crates.io locally - is there any documentation that I could read to figure out both of the above? Edit: I modified the HTML locally on the crates.io website to use "registry" instead of "host" and it is fitting on one line (MacOS with Chrome Version 61.0.3163.100 - 64 bit). Edit 2: Fitting on a single line in Safari Version 11.0 (12604.1.38.1.7). |
This is Chrome's DevTools docs: https://developer.chrome.com/devtools This is how to run a local server for the crates.io app: https://guides.emberjs.com/v2.15.0/getting-started/quick-start/ Since you've already tested in a couple of browsers, (and I've checked it in Chrome/Linux, and it looks good) I think we're good to go. @carols10cents? |
We should also keep in mind rust-lang/cargo#4208. As far as I can tell, the intent (after a depreciation cycle) is to allow people to pass something like |
Thanks, @jtgeibel, for bringing that up. In #950, we had a little discussion about it, but the issue of In RFC 2141, such a service is clearly named "registry". The keyword used in the CLI is And recently there's been PRs to replace So, I think it's safe to say that we want to call crates.io the "package registry" and not "package host" anymore. |
This looks great to me! Thank you!! bors: r+ |
Build succeeded |
@behnam @carols10cents Although the commit has been merged successfully, I still see "host" being used on crates.io instead of "registry". Did we miss something? |
Oh we don't have auto-deploy or anything. This'll go out when I next deploy, probably later today. Thanks! |
I lied, it went out today because of Reasons! It's out now-- you might have to do a shift-reload to clear browser cache, but I see it :) Thank you @seanprashad!!! |
Modified the
<h1>
header insideapp/templates/index.hbs
from "The Rust community’s crate host" to "The Rust community’s crate registry".