Use computed property for versions length #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug is causing `versions` to be fetched once for each version causing excessive queries to slow down or freeze the page. * Turn versions.length into a computed property to prevent extra requests
|
It seems like this might fix #107? |
|
Yep! I should have checked the issues for it. |
|
Awesome, thanks! |
alexcrichton
added a commit
that referenced
this pull request
Jan 5, 2015
Use computed property for versions length
|
Hm, it looks like there's still 3 requests made for versions, but it's certainly better than N! I'll see if I can't find them. |
Turbo87
added a commit
to Turbo87/crates.io
that referenced
this pull request
Jan 4, 2023
This allows us to lookup specific files without having to mutate the `path` of the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug is causing
versionsto be fetched once for each version causingexcessive queries to slow down or freeze the page.
requests
This only happens when you visit from the search. I found this by looking for "hyper" and clicking the first link and experiencing unresponsiveness. I'm not totally sure, but I think this might be a result of having both a
versionsattribute that is null from the search and having aversionsattribute inlinks.This could probably be avoided altogether by passing
version_idsinstead of the objects or links in addition to coalescing the requests. If you decide to go that way and need some help on the Ember side I'm more than happy to help implement that.