Re-enable syntax highlighting. #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `code` tag and corresponding `class` attribute to the whitelisted `tag_attributes`. - Added `allowed-classes` for the `code` tag. Test for adding classes to non whitelisted tags.
sgrif
approved these changes
Sep 21, 2017
There was a problem hiding this comment.
LGTM but @carols10cents should take a look at this before it's merged.
|
Looks great!! Thank you!! 🔴 🔵 ⚫️ ⚪️ bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Sep 23, 2017
1070: Re-enable syntax highlighting. r=carols10cents Syntax highlighting seems to be working as intended now. I tested by publishing a create locally with a `README.md` including a couple of code samples, see below for a screenshot. Thanks for the help, and please let me know if you have any questions. Closes #1008 <img width="963" alt="screen shot 2017-09-21 at 1 07 28 pm" src="https://user-images.githubusercontent.com/5225538/30719271-d79969e8-9ef0-11e7-878d-064a62a4dbeb.png">
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax highlighting seems to be working as intended now. I tested by publishing a create locally with a
README.mdincluding a couple of code samples, see below for a screenshot. Thanks for the help, and please let me know if you have any questions.Closes #1008