-
Notifications
You must be signed in to change notification settings - Fork 642
[styles] Make header subtitle fit in one line #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After shipping the update to header title/subtitle and testing it with logged-in user, the subtitle was broken into two lines, breaking the layout. Making the subtitle a bit smaller fixes the problem. See <rust-lang#1031>
@behnam This repo hasn't got automatic review assigning set up, so the |
Thanks for the reminder, @vignesh-sankaran. :) My comment is intended to ping the person for a review, but not the auto-assign bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution is still showing 2 lines for me :-/
This PR fixes the specific problem of "Rust Package Registry" breaking into two lines (in some cases, like when logged in and name is long enough), because of it being longer that the "crates.io" text. To fix the top-right corner text to be fixed, I think we better just wait for the overall site redesign and consider these cases there. IMHO, the current design doesn't have much room for a nice fix, and spending more time would be duplicate work of the site redesign. With that, I suggest to just land this to fix the first problem, and take the second to the tracker task for redesign. What do you think? |
Sure, fine. There's no timeline for the redesign though. bors: r+ |
1044: [styles] Make header subtitle fit in one line r=carols10cents After shipping the update to header title/subtitle and testing it with logged-in user, the subtitle was broken into two lines, breaking the layout. Making the subtitle a bit smaller fixes the problem. See <#1031>
Build succeeded |
After shipping the update to header title/subtitle and testing it with
logged-in user, the subtitle was broken into two lines, breaking the
layout. Making the subtitle a bit smaller fixes the problem.
See #1031