Skip to content

[styles] Make header subtitle fit in one line #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2017

Conversation

behnam
Copy link
Contributor

@behnam behnam commented Sep 6, 2017

After shipping the update to header title/subtitle and testing it with
logged-in user, the subtitle was broken into two lines, breaking the
layout. Making the subtitle a bit smaller fixes the problem.

See #1031

After shipping the update to header title/subtitle and testing it with
logged-in user, the subtitle was broken into two lines, breaking the
layout. Making the subtitle a bit smaller fixes the problem.

See <rust-lang#1031>
@behnam
Copy link
Contributor Author

behnam commented Sep 6, 2017

r? @carols10cents

@vignesh-sankaran
Copy link
Contributor

@behnam This repo hasn't got automatic review assigning set up, so the r? command won't work here :)

@behnam
Copy link
Contributor Author

behnam commented Sep 6, 2017

This repo hasn't got automatic review assigning set up, so the r? command won't work here :)

Thanks for the reminder, @vignesh-sankaran. :) My comment is intended to ping the person for a review, but not the auto-assign bot.

Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is still showing 2 lines for me :-/

@carols10cents
Copy link
Member

So this doesn't fix it for all names, and it's kind of unreadable at this point:

screen shot 2017-09-09 at 1 19 23 pm

In fact, long names probably had this problem before changing the header text.

Do you have any ideas on a way to make the wrapping make more sense instead, perhaps?

@behnam
Copy link
Contributor Author

behnam commented Sep 10, 2017

This PR fixes the specific problem of "Rust Package Registry" breaking into two lines (in some cases, like when logged in and name is long enough), because of it being longer that the "crates.io" text.

To fix the top-right corner text to be fixed, I think we better just wait for the overall site redesign and consider these cases there. IMHO, the current design doesn't have much room for a nice fix, and spending more time would be duplicate work of the site redesign.

With that, I suggest to just land this to fix the first problem, and take the second to the tracker task for redesign. What do you think?

@carols10cents
Copy link
Member

Sure, fine. There's no timeline for the redesign though.

bors: r+

bors-voyager bot added a commit that referenced this pull request Sep 10, 2017
1044: [styles] Make header subtitle fit in one line r=carols10cents

After shipping the update to header title/subtitle and testing it with
logged-in user, the subtitle was broken into two lines, breaking the
layout. Making the subtitle a bit smaller fixes the problem.

See <#1031>
@bors-voyager
Copy link
Contributor

bors-voyager bot commented Sep 10, 2017

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants