Improve code display #1002
Merged
Improve code display #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
improve-code-display
branch
from
71e3137 to
d739633
Compare
sgrif
reviewed
Aug 24, 2017
|
|
||
| p { | ||
| code { | ||
| background-color: #fff; |
There was a problem hiding this comment.
What's the purpose of this? It's not being rendered, and if it were the text would be unreadable.
There was a problem hiding this comment.
What? It's rendered perfectly for me and the text is readable as my screenshot shows it. The point is to make text code blocks stand out a bit more.
There was a problem hiding this comment.
The background color of the code block is not white...
There was a problem hiding this comment.
Oh I see, this is for inline code blocks. I misunderstood.
There was a problem hiding this comment.
Could you edit your commit message to be more clear on what this change is affecting?
GuillaumeGomez
force-pushed
the
improve-code-display
branch
from
d739633 to
5e0eca8
Compare
|
@sgrif: Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little screenshot with the new style:
As you can see, the
codeelements inside the texts are now easier to spot and I find it more attractive when reading.