Skip to content

Possible anti-pattern for using sudo to install node/npm/yarn in CONTRIBUTING.md #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
locks opened this issue Jun 26, 2017 · 0 comments
Closed

Possible anti-pattern for using sudo to install node/npm/yarn in CONTRIBUTING.md #809

locks opened this issue Jun 26, 2017 · 0 comments
Labels
C-bug 🐞 Category: unintended, undesired behavior question ❔

Comments

@locks
Copy link
Contributor

locks commented Jun 26, 2017

CONTRIBUTING.md has the following note, which I believe is an anti-practice:

> Note that you may need to install these as root using sudo in some cases.

As far as I know, installing node/npm/yarn with sudo is not recommended and a sign that something went wrong with the installation process.
Can someone else confirm that we should remove it? cc @ashleygwilliams
@carols10cents carols10cents changed the title Possible anti-pattern in CONTRIBUTING.me Possible anti-pattern for using sudo to install node/npm/yarn in CONTRIBUTING.md Jun 26, 2017
@vignesh-sankaran vignesh-sankaran mentioned this issue Aug 1, 2017
Merged
@carols10cents carols10cents added the C-bug 🐞 Category: unintended, undesired behavior label Aug 2, 2017
bors-voyager bot added a commit that referenced this issue Aug 14, 2017
@bors-voyager
Merge #927
d6eaeb8 
927: Add steps to avoid sudo for npm and node on Linux r=carols10cents

Resolves #809 by recommending `nvm` to install `node` and `npm` on Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug 🐞 Category: unintended, undesired behavior question ❔
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@locks @carols10cents