Skip to content

Website renders incorrectly on mobile browsers #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Dec 31, 2016 · 3 comments
Closed

Website renders incorrectly on mobile browsers #499

ghost opened this issue Dec 31, 2016 · 3 comments
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior

Comments

@ghost
Copy link

ghost commented Dec 31, 2016

I am using Chrome on Android.
See the attached long screenshot for the issue -
s61231-15384577 1 1 1 1 1

@ducks
Copy link

ducks commented Jan 30, 2017

It looks like the above screenshot, and the cargo docs in general, aren't contained in the same crates.io repo. They are located here https://github.com/rust-lang/cargo/tree/master/src/doc and hosted on the http://doc.crates.io/index.html subdomain.

This means the two sites are using different html, css, etc. It kind of makes sense to me to keep at this content in one place, but I also see the benefit of keeping cargo docs in the cargo repo.

We would need to either 1) fix the responsive stuff on the cargo docs side which includes some html tweaking and css changes I think, or 2) move the cargo docs content to static ember pages hosted on crates.io which is already responsive.

Any thoughts on which way to handle this one? @carols10cents

@carols10cents
Copy link
Member

Yeah, there have been multiple issues with the HTML/JS/CSS that's duplicated between the two repos getting out of sync. I wonder if there's a not-too-complex way that the text of the cargo docs could continue to live in the cargo repo, but could be fetched and inserted into the HTML/JS/CSS that lives in the crates.io repo...?

@carols10cents carols10cents added the C-bug 🐞 Category: unintended, undesired behavior label Aug 2, 2017
@carols10cents
Copy link
Member

I'm closing this since the cargo docs are moving to mdbook and are going to be rendered completely differently :)

bors added a commit that referenced this issue Dec 18, 2019
….2, r=Turbo87

Bump qunit-dom from 0.9.0 to 0.9.2

Bumps [qunit-dom](https://github.com/simplabs/qunit-dom) from 0.9.0 to 0.9.2.
<details>
<summary>Release notes</summary>

*Sourced from [qunit-dom's releases](https://github.com/simplabs/qunit-dom/releases).*

> ## v0.9.1
> #### 🚀 Enhancement
> * [#496](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/496) Adding `hasTagName()` assertion ([@&#8203;scalvert](https://github.com/scalvert))
> * [#451](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/451) Adds regex support for CSS class assertions ([@&#8203;timiyay](https://github.com/timiyay))
>
> #### 🏠 Internal
> * [#407](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/407) Update ESLint-Typescript tooling ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### Committers: 4
> - Stephen Yeung ([@&#8203;step2yeung](https://github.com/step2yeung))
> - Steve Calvert ([@&#8203;scalvert](https://github.com/scalvert))
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
> - [@&#8203;timiyay](https://github.com/timiyay)
</details>
<details>
<summary>Changelog</summary>

*Sourced from [qunit-dom's changelog](https://github.com/simplabs/qunit-dom/blob/master/CHANGELOG.md).*

> ## v0.9.2 (2019-11-12)
>
> #### 🚀 Enhancement
> * [#535](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/535) isChecked: Add support for `aria-checked="true/false"` ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### 📝 Documentation
> * [#530](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/530) Update Changelog ([@&#8203;tniezurawski](https://github.com/tniezurawski))
>
> #### Committers: 2
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
> - Tomasz Nieżurawski ([@&#8203;tniezurawski](https://github.com/tniezurawski))
>
>
> ## v0.9.1 (2019-10-28)
>
> #### 🚀 Enhancement
> * [#499](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/499) Add `hasNoText()` assertion ([@&#8203;step2yeung](https://github.com/step2yeung))
> * [#501](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/501) Add `doesNotHaveTagName()` assertion ([@&#8203;scalvert](https://github.com/scalvert))
> * [#496](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/496) Add `hasTagName()` assertion ([@&#8203;scalvert](https://github.com/scalvert))
> * [#451](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/451) Add regex support for CSS class assertions ([@&#8203;timiyay](https://github.com/timiyay))
>
> #### 🏠 Internal
> * [#498](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/498) Fix tests to correctly ignore dist output ([@&#8203;scalvert](https://github.com/scalvert))
> * [#407](https://github-redirect.dependabot.com/simplabs/qunit-dom/pull/407) Update ESLint-Typescript tooling ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### Committers: 4
> - Stephen Yeung ([@&#8203;step2yeung](https://github.com/step2yeung))
> - Steve Calvert ([@&#8203;scalvert](https://github.com/scalvert))
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
> - [@&#8203;timiyay](https://github.com/timiyay)
</details>
<details>
<summary>Commits</summary>

- [`eb42c68`](mainmatter/qunit-dom@eb42c68) v0.9.2
- [`57c73b5`](mainmatter/qunit-dom@57c73b5) Merge pull request [#535](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/535) from Turbo87/aria-checked
- [`dc1619e`](mainmatter/qunit-dom@dc1619e) build(deps-dev): bump rollup from 1.26.4 to 1.26.5 ([#536](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/536))
- [`308a688`](mainmatter/qunit-dom@308a688) build(deps-dev): bump lerna-changelog from 0.8.2 to 0.8.3 ([#537](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/537))
- [`aec772a`](mainmatter/qunit-dom@aec772a) isChecked: Add support for `aria-checked="true/false"`
- [`016ee2d`](mainmatter/qunit-dom@016ee2d) build(deps-dev): bump rollup-plugin-typescript2 from 0.24.3 to 0.25.2 ([#527](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/527))
- [`5613807`](mainmatter/qunit-dom@5613807) build(deps-dev): bump prettier from 1.18.2 to 1.19.1 ([#533](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/533))
- [`5548ba0`](mainmatter/qunit-dom@5548ba0) build(deps-dev): bump rollup from 1.26.3 to 1.26.4 ([#534](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/534))
- [`2cdac6c`](mainmatter/qunit-dom@2cdac6c) Update Changelog ([#530](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/530))
- [`8959924`](mainmatter/qunit-dom@8959924) build(deps-dev): bump @types/jest from 24.0.21 to 24.0.22 ([#529](https://github-redirect.dependabot.com/simplabs/qunit-dom/issues/529))
- Additional commits viewable in [compare view](mainmatter/qunit-dom@v0.9.0...v0.9.2)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=qunit-dom&package-manager=npm_and_yarn&previous-version=0.9.0&new-version=0.9.2)](https://dependabot.com/compatibility-score.html?dependency-name=qunit-dom&package-manager=npm_and_yarn&previous-version=0.9.0&new-version=0.9.2)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

3 participants