-
Notifications
You must be signed in to change notification settings - Fork 645
Regression in rendering of dependency version requirements #3047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I looked into this a little bit, and what happens is that on upload we parse the requirement string into a Unfortunately, the new From what I can tell we don't use the |
Save original dependency requirement string in the database when publishing This PR should resolve #3047 by saving the original dependency requirement string in the database when publishing, and returning the original string too when calling the `GET /crates/:crate_id/:version/dependencies` endpoint. Before #2990 we were turning `1.2.3` into `^1.2.3` automatically. After that PR were turning it into `>=1.2.3, <2.0.0`, and now, with this PR, we would keep it at `1.2.3` and it would be up to the API client to prefix the `^`, if necessary. r? `@jtgeibel` /cc `@dtolnay`
This reverts commit 0bcb724. This reverts the revert (rust-lang#3051) of rust-lang#2990. Now that rust-lang#3047 is resolved by rust-lang#3094, it should be fine to bump this again.
This reverts commit 0bcb724. This reverts the revert (rust-lang#3051) of rust-lang#2990. Now that rust-lang#3047 is resolved by
Uh oh!
There was an error while loading. Please reload this page.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The screenshot on the left is much easier for me to read off the information that I care about. The
>=A.B.C, <D.E.F
ranges are just unnecessarily verbose/cluttered and disguises when there are real>=
/<
dependencies that are not equivalent to a^
dependency (as in>=0.2, <0.4
). 😕Additional context
If this was not made as an intentional change, it's possible it was introduced inadvertently in the course of a dependency update such as #2990.
The text was updated successfully, but these errors were encountered: