Skip to content

Broken "Menu ▼" dropdown #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panicbit opened this issue Dec 16, 2015 · 7 comments
Closed

Broken "Menu ▼" dropdown #239

panicbit opened this issue Dec 16, 2015 · 7 comments

Comments

@panicbit
Copy link
Contributor

The "Menu ▼" dropdown in the layout for small devices is broken.
Clicking it only results in an error in the JS console:

error

@alexcrichton
Copy link
Member

cc @Turbo87

@panicbit
Copy link
Contributor Author

741a77f seems to have introduced the problem.

@panicbit
Copy link
Contributor Author

I've tried to implement the rl-dropdown for the menu bar, which worked fine except the dropdown isn't closing on submitting a search query.
rl-dropdown doesn't seem to provide an easy option in this in use case.
Maybe making the dropdown a custom component in addition to using the rl-dropdown mixin is the best approach here but I failed to set that up properly 😞.

@softprops
Copy link

+1 was just going to post a new issue but saw this instead. I primarily use crates.io as a search engine. Any chance of rethinking the ux of search and making the search something you don't have to click into a menu to find? I'm not a designer but I'd be happy to give it a shot.

@panicbit
Copy link
Contributor Author

panicbit commented Jan 6, 2016

I agree, searching for crates is an essential part, so keeping the searchbar visible even for mobile devices would be ok. Doing so would allow us to fix the dropdown menu since the searchbar is the only problematic thing.

@Turbo87
Copy link
Member

Turbo87 commented Jan 11, 2016

still on vacation with patchy Internet connection, but I'll have a look
once I'm back (unless someone else fixes it before that)

panicbit [email protected] schrieb am Mi., 6. Jan. 2016 12:34:

I agree, searching for crates is an essential part, so keeping it on the
page even for mobile devices would be ok. Doing so would allow us to fix
the dropdown menu since the searchbar is the only problematic thing.


Reply to this email directly or view it on GitHub
#239 (comment)
.

@alexcrichton
Copy link
Member

Fixed in #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants