Prefer lower() to to_lowercase()

Author: JohnTitor

src/controllers/user/other.rs

@@ -9,7 +9,7 @@ use crate::views::EncodablePublicUser;
 pub fn show(req: &mut dyn RequestExt) -> EndpointResult {
     use self::users::dsl::{gh_login, id, users};
 
-    let name = &req.params()["user_id"].to_lowercase();
+    let name = crate::lower(&req.params()["user_id"]);
     let conn = req.db_conn()?;
     let user = users
         .filter(crate::lower(gh_login).eq(name))

src/tests/user.rs

@@ -142,14 +142,14 @@ fn me() {
 #[test]
 fn show() {
     let (app, anon, _) = TestApp::init().with_user();
-    app.db_new_user("bar");
+    app.db_new_user("Bar");
 
     let json: UserShowPublicResponse = anon.get("/api/v1/users/foo").good();
     assert_eq!("foo", json.user.login);
 
-    let json: UserShowPublicResponse = anon.get("/api/v1/users/bar").good();
-    assert_eq!("bar", json.user.login);
-    assert_eq!(Some("https://github.com/bar".into()), json.user.url);
+    let json: UserShowPublicResponse = anon.get("/api/v1/users/bAr").good();
+    assert_eq!("Bar", json.user.login);
+    assert_eq!(Some("https://github.com/Bar".into()), json.user.url);
 }
 
 #[test]