Auto merge of #1735 - jtgeibel:clippy-cleanups, r=jtgeibel

Clippy cleanups

This series first addresses a warning now produced on nightly.  Then `clippy::all` and `rust_2018_idioms` are explicitly denied for all lib, bin, and test artifacts.

By denying `clippy::all`, the RLS will automatically show clippy warnings in an IDE.  This only affects the RLS and `cargo clippy --all-targets` should still used in a command line workflow.

Author: bors

src/background_jobs.rs

@@ -44,7 +44,7 @@ impl Environment {
             .map(|(u, p)| (u.as_str(), p.as_str()))
     }
 
-    pub fn connection(&self) -> CargoResult<DieselPooledConn> {
+    pub fn connection(&self) -> CargoResult<DieselPooledConn<'_>> {
         self.connection_pool.0.get().map_err(Into::into)
     }
 

src/bin/background-worker.rs

@@ -7,7 +7,7 @@
 // Usage:
 //      cargo run --bin background-worker
 
-#![deny(warnings)]
+#![deny(warnings, clippy::all, rust_2018_idioms)]
 
 use cargo_registry::git::Repository;
 use cargo_registry::{background_jobs::*, db};

src/bin/delete-crate.rs

@@ -5,7 +5,7 @@
 // Usage:
 //      cargo run --bin delete-crate crate-name
 
-#![deny(warnings)]
+#![deny(warnings, clippy::all, rust_2018_idioms)]
 
 use cargo_registry::{db, models::Crate, schema::crates};
 use std::{

src/bin/delete-version.rs

@@ -5,7 +5,7 @@
 // Usage:
 //      cargo run --bin delete-version crate-name version-number
 
-#![deny(warnings)]
+#![deny(warnings, clippy::all, rust_2018_idioms)]
 
 use cargo_registry::{
     db,

src/bin/monitor.rs

@@ -4,7 +4,7 @@
 //! Usage:
 //!     cargo run --bin monitor
 
-#![deny(warnings)]
+#![deny(warnings, clippy::all, rust_2018_idioms)]
 
 mod on_call;
 

src/bin/populate.rs

@@ -4,7 +4,7 @@
 // Usage:
 //      cargo run --bin populate version_id1 version_id2 ...
 
-#![deny(warnings)]
+#![deny(warnings, clippy::all, rust_2018_idioms)]
 
 use cargo_registry::{db, schema::version_downloads};
 use std::env;

src/bin/render-readmes.rs

@@ -3,7 +3,7 @@
 //
 // Warning: this can take a lot of time.
 
-#![deny(warnings)]
+#![deny(warnings, clippy::all, rust_2018_idioms)]
 
 #[macro_use]
 extern crate serde;

src/bin/server.rs

@@ -1,4 +1,4 @@
-#![deny(warnings)]
+#![deny(warnings, clippy::all, rust_2018_idioms)]
 
 use cargo_registry::{boot, App, Env};
 use jemalloc_ctl;

src/bin/test-pagerduty.rs

@@ -5,7 +5,7 @@
 //!
 //! Event type can be trigger, acknowledge, or resolve
 
-#![deny(warnings)]
+#![deny(warnings, clippy::all, rust_2018_idioms)]
 
 mod on_call;
 

src/bin/transfer-crates.rs

@@ -3,7 +3,7 @@
 // Usage:
 //      cargo run --bin transfer-crates from-user to-user
 
-#![deny(warnings)]
+#![deny(warnings, clippy::all, rust_2018_idioms)]
 
 use cargo_registry::{
     db,