Skip to content

Commit 1b416a4

Browse files
authored
database/tests/schema_details: Use async queries (#10010)
1 parent bbe5d44 commit 1b416a4

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

Cargo.lock

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/crates_io_database/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,5 @@ diesel_full_text_search = "=2.2.0"
1313

1414
[dev-dependencies]
1515
crates_io_test_db = { path = "../crates_io_test_db" }
16+
diesel-async = { version = "=0.5.1", features = ["postgres"] }
17+
tokio = { version = "=1.41.1", features = ["macros", "rt"] }

crates/crates_io_database/tests/schema_details.rs

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
use crates_io_test_db::TestDatabase;
22
use diesel::prelude::*;
33
use diesel::sql_types::Text;
4+
use diesel_async::RunQueryDsl;
45

5-
#[test]
6-
fn all_columns_called_crate_id_have_a_cascading_foreign_key() {
7-
for row in get_fk_constraint_definitions("crate_id") {
6+
#[tokio::test]
7+
async fn all_columns_called_crate_id_have_a_cascading_foreign_key() {
8+
for row in get_fk_constraint_definitions("crate_id").await {
89
let constraint = match row.constraint {
910
Some(c) => c,
1011
None => panic!(
@@ -22,9 +23,9 @@ fn all_columns_called_crate_id_have_a_cascading_foreign_key() {
2223
}
2324
}
2425

25-
#[test]
26-
fn all_columns_called_version_id_have_a_cascading_foreign_key() {
27-
for row in get_fk_constraint_definitions("version_id") {
26+
#[tokio::test]
27+
async fn all_columns_called_version_id_have_a_cascading_foreign_key() {
28+
for row in get_fk_constraint_definitions("version_id").await {
2829
let constraint = match row.constraint {
2930
Some(c) => c,
3031
None => panic!(
@@ -66,14 +67,15 @@ struct TableNameAndConstraint {
6667
constraint: Option<FkConstraint>,
6768
}
6869

69-
fn get_fk_constraint_definitions(column_name: &str) -> Vec<TableNameAndConstraint> {
70+
async fn get_fk_constraint_definitions(column_name: &str) -> Vec<TableNameAndConstraint> {
7071
use diesel::sql_query;
7172

7273
let test_db = TestDatabase::new();
73-
let mut conn = test_db.connect();
74+
let mut conn = test_db.async_connect().await;
7475

7576
sql_query(include_str!("load_foreign_key_constraints.sql"))
7677
.bind::<Text, _>(column_name)
7778
.load(&mut conn)
79+
.await
7880
.unwrap()
7981
}

0 commit comments

Comments
 (0)