Add signed division functions #44
Conversation
Amanieu
force-pushed
the
sdiv
branch
3 times, most recently
from
5382cf5 to
aa2561a
Compare
|
|
||
| #[naked] | ||
| #[cfg_attr(not(test), no_mangle)] | ||
| pub unsafe fn __aeabi_idivmod() { |
There was a problem hiding this comment.
Would it make sense to add a test for this assembly routine (and the one below)? Just to check its expected signature (fn(u32, u32) -> (u32,u32) in this case, I think) works as expected?
|
I thought the aeabi intrinsics could have been tested by calling |
|
Yea, you need asm to call them with the custom convention. |
src/sdiv.rs
Outdated
| } | ||
|
|
||
| macro_rules! divmod { | ||
| ($intrinsic:ident, $div:ident: $ty:ty, $uty:ty) => { |
There was a problem hiding this comment.
$uty is not used in this macro?
OK. Thanks for clarifying. I left some comments about nits. r=me after those are addressed. |
Amanieu
force-pushed
the
sdiv
branch
2 times, most recently
from
ca354ff to
95d3b84
Compare
|
Thanks @Amanieu! |
108: coshf tanhf and atan2f r=japaric a=burrbull closes rust-lang#44 closes rust-lang#52 closes rust-lang#41 Co-authored-by: Andrey Zgarbul <[email protected]> Co-authored-by: Zgarbul Andrey <[email protected]>
No description provided.