Upload dependency kinds to the registry #939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let kind = match kind.as_ref().map(|s| s.as_slice()).unwrap_or("") { | ||
| "dev" => Kind::Development, | ||
| "build" => Kind::Build, | ||
| _ => Kind::Normal, |
There was a problem hiding this comment.
Maybe this could be "normal" => Kind::Normal, s => panic!("unknown kind: {}", s) to assist with future refactorings?
There was a problem hiding this comment.
I was actually hoping that this would help with future compatibility in that if an older version of cargo were used with a more recent version of the registry (with a newer kind available) that it would just interpret the dependency as a normal dependency rather than a special one. Not sure how useful that would be though...
This ensures that the registry understands whether dependencies are build dependencies or dev dependencies. Closes rust-lang/crates.io#38
alexcrichton
force-pushed
the
issue-38
branch
from
a510866 to
3b5994e
Compare
bors
added a commit
that referenced
this pull request
Nov 24, 2014
This ensures that the registry understands whether dependencies are build dependencies or dev dependencies. Closes rust-lang/crates.io#38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the registry understands whether dependencies are build
dependencies or dev dependencies.
Closes rust-lang/crates.io#38