Auto merge of #13506 - epage:context, r=weihanglo

refactor: Clarify more Config -> Context

### What does this PR try to resolve?

This is a follow up to #13409 and #13486

### How should we test and review this PR?

### Additional information

Author: bors

crates/xtask-bump-check/src/main.rs

@@ -6,7 +6,7 @@ fn main() {
     let cli = xtask::cli();
     let matches = cli.get_matches();
 
-    let mut gctx = cargo::util::config::GlobalContext::default().unwrap_or_else(|e| {
+    let mut gctx = cargo::util::context::GlobalContext::default().unwrap_or_else(|e| {
         let mut eval = cargo::core::shell::Shell::new();
         cargo::exit_with_error(e.into(), &mut eval)
     });

src/bin/cargo/cli.rs

@@ -1,6 +1,6 @@
 use anyhow::{anyhow, Context as _};
 use cargo::core::{features, CliUnstable};
-use cargo::util::config::TermConfig;
+use cargo::util::context::TermConfig;
 use cargo::{drop_print, drop_println, CargoResult};
 use clap::builder::UnknownArgumentValueParser;
 use itertools::Itertools;
@@ -57,21 +57,21 @@ pub fn main(gctx: &mut GlobalContext) -> CliResult {
         == Some("help")
     {
         // Don't let config errors get in the way of parsing arguments
-        let _ = config_configure(gctx, &expanded_args, None, global_args, None);
+        let _ = configure_gctx(gctx, &expanded_args, None, global_args, None);
         print_zhelp(gctx);
     } else if expanded_args.flag("version") {
         // Don't let config errors get in the way of parsing arguments
-        let _ = config_configure(gctx, &expanded_args, None, global_args, None);
+        let _ = configure_gctx(gctx, &expanded_args, None, global_args, None);
         let version = get_version_string(is_verbose);
         drop_print!(gctx, "{}", version);
     } else if let Some(code) = expanded_args.get_one::<String>("explain") {
         // Don't let config errors get in the way of parsing arguments
-        let _ = config_configure(gctx, &expanded_args, None, global_args, None);
+        let _ = configure_gctx(gctx, &expanded_args, None, global_args, None);
         let mut procss = gctx.load_global_rustc(None)?.process();
         procss.arg("--explain").arg(code).exec()?;
     } else if expanded_args.flag("list") {
         // Don't let config errors get in the way of parsing arguments
-        let _ = config_configure(gctx, &expanded_args, None, global_args, None);
+        let _ = configure_gctx(gctx, &expanded_args, None, global_args, None);
         print_list(gctx, is_verbose);
     } else {
         let (cmd, subcommand_args) = match expanded_args.subcommand() {
@@ -83,7 +83,7 @@ pub fn main(gctx: &mut GlobalContext) -> CliResult {
             }
         };
         let exec = Exec::infer(cmd)?;
-        config_configure(
+        configure_gctx(
             gctx,
             &expanded_args,
             Some(subcommand_args),
@@ -377,7 +377,7 @@ For more information, see issue #12207 <https://github.com/rust-lang/cargo/issue
     Ok((args, GlobalArgs::default()))
 }
 
-fn config_configure(
+fn configure_gctx(
     gctx: &mut GlobalContext,
     args: &ArgMatches,
     subcommand_args: Option<&ArgMatches>,

src/cargo/core/compiler/build_config.rs

@@ -1,5 +1,5 @@
 use crate::core::compiler::CompileKind;
-use crate::util::config::JobsConfig;
+use crate::util::context::JobsConfig;
 use crate::util::interning::InternedString;
 use crate::util::{CargoResult, GlobalContext, RustfixDiagnosticServer};
 use anyhow::{bail, Context as _};

src/cargo/core/compiler/build_context/mod.rs

@@ -5,7 +5,7 @@ use crate::core::compiler::{BuildConfig, CompileKind, Unit};
 use crate::core::profiles::Profiles;
 use crate::core::PackageSet;
 use crate::core::Workspace;
-use crate::util::config::GlobalContext;
+use crate::util::context::GlobalContext;
 use crate::util::errors::CargoResult;
 use crate::util::interning::InternedString;
 use crate::util::Rustc;

src/cargo/core/compiler/build_context/target_info.rs

@@ -12,7 +12,7 @@ use crate::core::compiler::{
     BuildOutput, BuildRunner, CompileKind, CompileMode, CompileTarget, CrateType,
 };
 use crate::core::{Dependency, Package, Target, TargetKind, Workspace};
-use crate::util::config::{GlobalContext, StringList, TargetConfig};
+use crate::util::context::{GlobalContext, StringList, TargetConfig};
 use crate::util::interning::InternedString;
 use crate::util::{CargoResult, Rustc};
 use anyhow::Context as _;

src/cargo/core/compiler/compilation.rs

@@ -11,7 +11,7 @@ use crate::core::compiler::apply_env_config;
 use crate::core::compiler::BuildContext;
 use crate::core::compiler::{CompileKind, Metadata, Unit};
 use crate::core::Package;
-use crate::util::{config, CargoResult, GlobalContext};
+use crate::util::{context, CargoResult, GlobalContext};
 
 /// Represents the kind of process we are creating.
 #[derive(Debug)]
@@ -453,7 +453,7 @@ fn target_runner(
     // try target.{}.runner
     let key = format!("target.{}.runner", target);
 
-    if let Some(v) = bcx.gctx.get::<Option<config::PathAndArgs>>(&key)? {
+    if let Some(v) = bcx.gctx.get::<Option<context::PathAndArgs>>(&key)? {
         let path = v.path.resolve_program(bcx.gctx);
         return Ok(Some((path, v.args)));
     }

src/cargo/core/features.rs

@@ -112,7 +112,7 @@
 //!    and summarize it similar to the other entries. Update the rest of the
 //!    documentation to add the new feature.
 //!
-//! [`GlobalContext::cli_unstable`]: crate::util::config::GlobalContext::cli_unstable
+//! [`GlobalContext::cli_unstable`]: crate::util::context::GlobalContext::cli_unstable
 //! [`fail_if_stable_opt`]: CliUnstable::fail_if_stable_opt
 //! [`features!`]: macro.features.html
 //! [`unstable_cli_options!`]: macro.unstable_cli_options.html

src/cargo/core/profiles.rs

@@ -30,7 +30,7 @@ use crate::core::{
 };
 use crate::util::interning::InternedString;
 use crate::util::toml::validate_profile;
-use crate::util::{closest_msg, config, CargoResult, GlobalContext};
+use crate::util::{closest_msg, context, CargoResult, GlobalContext};
 use anyhow::{bail, Context as _};
 use cargo_util_schemas::manifest::TomlTrimPaths;
 use cargo_util_schemas::manifest::TomlTrimPathsValue;
@@ -1298,7 +1298,7 @@ fn merge_config_profiles(
 
 /// Helper for fetching a profile from config.
 fn get_config_profile(ws: &Workspace<'_>, name: &str) -> CargoResult<Option<TomlProfile>> {
-    let profile: Option<config::Value<TomlProfile>> =
+    let profile: Option<context::Value<TomlProfile>> =
         ws.gctx().get(&format!("profile.{}", name))?;
     let Some(profile) = profile else {
         return Ok(None);

src/cargo/core/resolver/mod.rs

@@ -67,7 +67,7 @@ use tracing::{debug, trace};
 
 use crate::core::PackageIdSpec;
 use crate::core::{Dependency, PackageId, Registry, Summary};
-use crate::util::config::GlobalContext;
+use crate::util::context::GlobalContext;
 use crate::util::errors::CargoResult;
 use crate::util::network::PollExt;
 use crate::util::profile;

src/cargo/core/source_id.rs

@@ -6,7 +6,7 @@ use crate::sources::source::Source;
 use crate::sources::{DirectorySource, CRATES_IO_DOMAIN, CRATES_IO_INDEX, CRATES_IO_REGISTRY};
 use crate::sources::{GitSource, PathSource, RegistrySource};
 use crate::util::interning::InternedString;
-use crate::util::{config, CanonicalUrl, CargoResult, GlobalContext, IntoUrl};
+use crate::util::{context, CanonicalUrl, CargoResult, GlobalContext, IntoUrl};
 use anyhow::Context as _;
 use serde::de;
 use serde::ser;
@@ -268,7 +268,7 @@ impl SourceId {
 
     /// Returns whether to access crates.io over the sparse protocol.
     pub fn crates_io_is_sparse(gctx: &GlobalContext) -> CargoResult<bool> {
-        let proto: Option<config::Value<String>> = gctx.get("registries.crates-io.protocol")?;
+        let proto: Option<context::Value<String>> = gctx.get("registries.crates-io.protocol")?;
         let is_sparse = match proto.as_ref().map(|v| v.val.as_str()) {
             Some("sparse") => true,
             Some("git") => false,