Commit 23c36f5
committed
Auto merge of #14704 - Muscraft:fix-renovate, r=weihanglo
fix(renovate): Switch matchPackageNames to matchDepNames
When talking to `@weihanglo` about #14703, it was noticed that `renovate` was ignoring `extractVersion` and `schedule` for [`MSRV:1`](https://github.com/rust-lang/cargo/blob/cf53cc54bb593b5ec3dc2be4b1702f50c36d24d5/.github/renovate.json5#L50-L53) and [`MSRV:3`](https://github.com/rust-lang/cargo/blob/cf53cc54bb593b5ec3dc2be4b1702f50c36d24d5/.github/renovate.json5#L64-L67). After a lot of digging into why that was happening, I figured out that it was caused by a [breaking change in `renovate@38`](https://github.com/renovatebot/renovate/releases/tag/38.0.0):
> **package-rules**: `matchPackageNames` and related functions no longer fall back to checking `depName`.
This change caused `renovate` to no longer apply the configuration from `packageRules` to `MSRV:1` and `MSRV:3` as the `customManagers` for both specified [`depNameTemplate`](https://github.com/rust-lang/cargo/blob/cf53cc54bb593b5ec3dc2be4b1702f50c36d24d5/.github/renovate.json5#L23) which is no longer being read.
To fix this issue, I changed `matchPackageNames` to `matchDepNames`, which solved the issue when I was testing locally.1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| |||
0 commit comments