Skip to content

ci: Fix the binary size workflow #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/build-with-patched-std/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@ runs:
# symlink on Linux and a junction on Windows, so it will exist on both
# platforms.
RUSTC_BUILD_DIR: build/host
RUST_BACKTRACE: 1
working-directory: ${{ inputs.rustc-dir }}
run: |
set -x
rm -rf "$RUSTC_BUILD_DIR/stage0-std"

(cd library/backtrace && git checkout ${{ inputs.backtrace-commit }})
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/check-binary-size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ on:
# Both the "measure" and "report" jobs need to know this.
env:
SIZE_DATA_DIR: sizes
RUST_BACKTRACE: 1

# Responsibility is divided between two jobs "measure" and "report", so that the
# job that builds (and potentnially runs) untrusted code does not have PR write
Expand Down Expand Up @@ -55,17 +56,20 @@ jobs:
with:
repository: rust-lang/rust
path: ${{ env.RUSTC_DIR }}
# Arbitrary version from 2024-04-28
ref: cc74ed08d53fbb440b4ab70035a92d89d418d23c
- name: Set up std repository and backtrace submodule for size test
shell: bash
working-directory: ${{ env.RUSTC_DIR }}
env:
PR_SOURCE_REPO: ${{ github.event.pull_request.head.repo.full_name }}
run: |
set -x
# Bootstrap config
cat <<EOF > config.toml
cat <<EOF > bootstrap.toml
change-id = 9999999
[llvm]
download-ci-llvm = true
download-ci-llvm = "if-unchanged"
[rust]
incremental = false
EOF
Expand Down
Loading